Skip to content

Commit bf8e9b4

Browse files
Add TODO comments for e2e test improvements
- FILE-level review comments: Document that they are silently dropped by GitHub API under certain conditions and the test doesn't fully verify them - Directory deletion: Document that the test only deletes a single file in a subdirectory, not actual recursive directory deletion
1 parent 5b7b3cd commit bf8e9b4

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

e2e/e2e_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -745,6 +745,12 @@ func TestDirectoryDeletion(t *testing.T) {
745745

746746
// Find the deletion commit (list_commits returns in reverse chronological order,
747747
// but timing can sometimes cause unexpected ordering)
748+
// TODO: The delete_file tool only deletes individual files, not directories.
749+
// This test creates a file in test-dir/ and deletes it, but doesn't actually
750+
// test recursive directory deletion. We should either:
751+
// 1. Rename TestDirectoryDeletion to TestFileDeletionInSubdirectory
752+
// 2. Implement actual directory deletion in the MCP server (delete all files in dir)
753+
// 3. Create multiple files and verify all are deleted
748754
var deletionCommit *struct {
749755
SHA string `json:"sha"`
750756
Commit struct {
@@ -1340,6 +1346,13 @@ func TestPullRequestReviewCommentSubmit(t *testing.T) {
13401346
require.Equal(t, "pending pull request created", textContent.Text)
13411347

13421348
// Add a file review comment
1349+
// TODO: FILE-level comments are silently dropped by GitHub API when:
1350+
// - The comment targets the wrong side of a diff
1351+
// - The comment targets a deleted part of a diff
1352+
// - The comment targets a line outside the actual diff range
1353+
// This test currently doesn't verify FILE-level comments are created because
1354+
// ListReviewComments API doesn't return them. We should investigate proper
1355+
// FILE-level comment parameters or use a different API to verify.
13431356

13441357
t.Logf("Adding file review comment to pull request in %s/%s...", currentOwner, repoName)
13451358
resp, err = mcpClient.CallTool(ctx, &mcp.CallToolParams{

0 commit comments

Comments
 (0)