From ec54100f38e090fbdd3a58070aa90497f8339206 Mon Sep 17 00:00:00 2001 From: Asger F Date: Fri, 5 Dec 2025 09:08:38 +0100 Subject: [PATCH 1/2] JS: Deprecate UnreachableMethodOverlaods This query needs a rewrite to ensure good performance, but it has too few results to justify doing this. --- javascript/ql/src/Declarations/UnreachableMethodOverloads.ql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql b/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql index 0088af1a2c0c..167e12950ae8 100644 --- a/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql +++ b/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql @@ -1,4 +1,5 @@ /** + * @deprecated * @name Unreachable method overloads * @description Having multiple overloads with the same parameter types in TypeScript * makes all overloads except the first one unreachable, as the compiler @@ -7,8 +8,7 @@ * @problem.severity warning * @id js/unreachable-method-overloads * @precision high - * @tags quality - * reliability + * @tags reliability * correctness * typescript */ From a9d4a1bef7c4c13faa27800396d6b6b750f92bfe Mon Sep 17 00:00:00 2001 From: Asger F Date: Fri, 5 Dec 2025 09:09:36 +0100 Subject: [PATCH 2/2] JS: Remove from suite expectations --- .../query-suite/javascript-code-quality-extended.qls.expected | 1 - .../query-suite/javascript-code-quality.qls.expected | 1 - .../query-suite/javascript-security-and-quality.qls.expected | 1 - 3 files changed, 3 deletions(-) diff --git a/javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected b/javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected index c9407089189e..3ac405d6fcde 100644 --- a/javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected +++ b/javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected @@ -28,7 +28,6 @@ ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql ql/javascript/ql/src/Declarations/TemporalDeadZone.ql ql/javascript/ql/src/Declarations/UniqueParameterNames.ql ql/javascript/ql/src/Declarations/UniquePropertyNames.ql -ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql ql/javascript/ql/src/Declarations/UnusedParameter.ql ql/javascript/ql/src/Declarations/UnusedVariable.ql ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql diff --git a/javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected b/javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected index b550c2c82492..bd648c82e810 100644 --- a/javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected +++ b/javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected @@ -24,7 +24,6 @@ ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql ql/javascript/ql/src/Declarations/TemporalDeadZone.ql ql/javascript/ql/src/Declarations/UniqueParameterNames.ql ql/javascript/ql/src/Declarations/UniquePropertyNames.ql -ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql ql/javascript/ql/src/Declarations/UnusedVariable.ql ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql ql/javascript/ql/src/Expressions/DuplicateCondition.ql diff --git a/javascript/ql/integration-tests/query-suite/javascript-security-and-quality.qls.expected b/javascript/ql/integration-tests/query-suite/javascript-security-and-quality.qls.expected index f87cd2bf505a..a2f0a3d43087 100644 --- a/javascript/ql/integration-tests/query-suite/javascript-security-and-quality.qls.expected +++ b/javascript/ql/integration-tests/query-suite/javascript-security-and-quality.qls.expected @@ -27,7 +27,6 @@ ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql ql/javascript/ql/src/Declarations/TemporalDeadZone.ql ql/javascript/ql/src/Declarations/UniqueParameterNames.ql ql/javascript/ql/src/Declarations/UniquePropertyNames.ql -ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql ql/javascript/ql/src/Declarations/UnusedVariable.ql ql/javascript/ql/src/Diagnostics/ExtractedFiles.ql ql/javascript/ql/src/Diagnostics/ExtractionErrors.ql