Swift: Convert some sinks to CSV.

Author: geoffw0

swift/ql/lib/codeql/swift/security/CleartextTransmissionExtensions.qll

@@ -30,38 +30,6 @@ class CleartextTransmissionAdditionalFlowStep extends Unit {
   abstract predicate step(DataFlow::Node nodeFrom, DataFlow::Node nodeTo);
 }
 
-/**
- * An `Expr` that is transmitted with `NWConnection.send`.
- */
-private class NWConnectionSendSink extends CleartextTransmissionSink {
-  NWConnectionSendSink() {
-    // `content` arg to `NWConnection.send` is a sink
-    exists(CallExpr call |
-      call.getStaticTarget()
-          .(Method)
-          .hasQualifiedName("NWConnection", "send(content:contentContext:isComplete:completion:)") and
-      call.getArgument(0).getExpr() = this.asExpr()
-    )
-  }
-}
-
-/**
- * An `Expr` that is used to form a `URL`. Such expressions are very likely to
- * be transmitted over a network, because that's what URLs are for.
- */
-private class UrlSink extends CleartextTransmissionSink {
-  UrlSink() {
-    // `string` arg in `URL.init` is a sink
-    // (we assume here that the URL goes on to be used in a network operation)
-    exists(CallExpr call |
-      call.getStaticTarget()
-          .(Method)
-          .hasQualifiedName("URL", ["init(string:)", "init(string:relativeTo:)"]) and
-      call.getArgument(0).getExpr() = this.asExpr()
-    )
-  }
-}
-
 /**
  * An `Expr` that transmitted through the Alamofire library.
  */
@@ -98,3 +66,16 @@ private class CleartextTransmissionDefaultBarrier extends CleartextTransmissionB
 private class DefaultCleartextTransmissionSink extends CleartextTransmissionSink {
   DefaultCleartextTransmissionSink() { sinkNode(this, "transmission") }
 }
+
+private class TransmissionSinks extends SinkModelCsv {
+  override predicate row(string row) {
+    row =
+      [
+        ";NWConnection;true;send(content:contentContext:isComplete:completion:);;;Argument[0];transmission",
+        // an `Expr` that is used to form a `URL` is very likely to be transmitted over a network, because
+        // that's what URLs are for.
+        ";URL;true;init(string:);;;Argument[0];transmission",
+        ";URL;true;init(string:relativeTo:);;;Argument[0];transmission",
+      ]
+  }
+}