Merge pull request #13973 from github/smowton/fix/go-version-comparison

smowton · web-flow · commit b8372c2f9591 · 2023-08-15T18:21:04.000+01:00
Go: Don't warn when Go version exactly matches go.mod
diff --git a/go/extractor/cli/go-autobuilder/go-autobuilder.go b/go/extractor/cli/go-autobuilder/go-autobuilder.go
@@ -773,7 +773,7 @@ func installDependenciesAndBuild() {
 
 	goModVersion, goModVersionFound := tryReadGoDirective(buildInfo)
 
-	if goModVersionFound && semver.Compare("v"+goModVersion, getEnvGoSemVer()) >= 0 {
+	if goModVersionFound && semver.Compare("v"+goModVersion, getEnvGoSemVer()) > 0 {
 		diagnostics.EmitNewerGoVersionNeeded()
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -773,7 +773,7 @@ func installDependenciesAndBuild() {`
`773`	`773`
`774`	`774`	`goModVersion, goModVersionFound := tryReadGoDirective(buildInfo)`
`775`	`775`
`776`		`- if goModVersionFound && semver.Compare("v"+goModVersion, getEnvGoSemVer()) >= 0 {`
	`776`	`+ if goModVersionFound && semver.Compare("v"+goModVersion, getEnvGoSemVer()) > 0 {`
`777`	`777`	`diagnostics.EmitNewerGoVersionNeeded()`
`778`	`778`	`}`
`779`	`779`