Merge pull request #7304 from michaelnebel/csharp-mad-as-csv2

C#: Convert flow summaries to CSV format.

Author: michaelnebel

csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll

@@ -92,6 +92,7 @@ private module Frameworks {
   private import semmle.code.csharp.frameworks.ServiceStack
   private import semmle.code.csharp.frameworks.Sql
   private import semmle.code.csharp.frameworks.EntityFramework
+  private import semmle.code.csharp.frameworks.system.Text
 }
 
 /**
@@ -262,7 +263,7 @@ module CsvValidation {
       not name.regexpMatch("[a-zA-Z0-9_<>,]*") and
       msg = "Dubious member name \"" + name + "\" in " + pred + " model."
       or
-      not signature.regexpMatch("|\\([a-zA-Z0-9_<>\\.\\+,\\[\\]]*\\)") and
+      not signature.regexpMatch("|\\([a-zA-Z0-9_<>\\.\\+\\*,\\[\\]]*\\)") and
       msg = "Dubious signature \"" + signature + "\" in " + pred + " model."
       or
       not ext.regexpMatch("|Attribute") and

csharp/ql/lib/semmle/code/csharp/dataflow/LibraryTypeDataFlow.qll

@@ -535,207 +535,8 @@ class SystemIOStringReaderFlow extends LibraryTypeDataFlow, SystemIOStringReader
   }
 }
 
-/** Data flow for `System.String`. */
-class SystemStringFlow extends LibraryTypeDataFlow, SystemStringClass {
-  override predicate callableFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    SourceDeclarationCallable c, boolean preservesValue
-  ) {
-    this.constructorFlow(source, sourceAp, sink, sinkAp, c) and
-    preservesValue = false
-    or
-    this.methodFlow(source, sourceAp, sink, sinkAp, c, preservesValue)
-  }
-
-  private predicate constructorFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    Constructor c
-  ) {
-    c = this.getAMember() and
-    c.getParameter(0).getType().(ArrayType).getElementType() instanceof CharType and
-    source = TCallableFlowSourceArg(0) and
-    sourceAp = AccessPath::element() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty()
-  }
-
-  private predicate methodFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    SourceDeclarationMethod m, boolean preservesValue
-  ) {
-    m = this.getAMethod("ToString") and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = true
-    or
-    m = this.getSplitMethod() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::element() and
-    preservesValue = false
-    or
-    m = this.getReplaceMethod() and
-    sourceAp = AccessPath::empty() and
-    sinkAp = AccessPath::empty() and
-    (
-      source = TCallableFlowSourceQualifier() and
-      sink = TCallableFlowSinkReturn() and
-      preservesValue = false
-      or
-      source = TCallableFlowSourceArg(1) and
-      sink = TCallableFlowSinkReturn() and
-      preservesValue = false
-    )
-    or
-    m = this.getSubstringMethod() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = false
-    or
-    m = this.getCloneMethod() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = true
-    or
-    m = this.getInsertMethod() and
-    sourceAp = AccessPath::empty() and
-    sinkAp = AccessPath::empty() and
-    (
-      source = TCallableFlowSourceQualifier() and
-      sink = TCallableFlowSinkReturn() and
-      preservesValue = false
-      or
-      source = TCallableFlowSourceArg(1) and
-      sink = TCallableFlowSinkReturn() and
-      preservesValue = false
-    )
-    or
-    m = this.getNormalizeMethod() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = false
-    or
-    m = this.getRemoveMethod() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = false
-    or
-    m = this.getAMethod() and
-    m.getName().regexpMatch("((ToLower|ToUpper)(Invariant)?)|(Trim(Start|End)?)|(Pad(Left|Right))") and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = false
-    or
-    m = this.getConcatMethod() and
-    exists(int i |
-      source = getFlowSourceArg(m, i, sourceAp) and
-      sink = TCallableFlowSinkReturn() and
-      sinkAp = AccessPath::empty() and
-      preservesValue = false
-    )
-    or
-    m = this.getCopyMethod() and
-    source = TCallableFlowSourceArg(0) and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = true
-    or
-    m = this.getJoinMethod() and
-    source = getFlowSourceArg(m, [0, 1], sourceAp) and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty() and
-    preservesValue = false
-    or
-    m = this.getFormatMethod() and
-    exists(int i |
-      (m.getParameter(0).getType() instanceof SystemIFormatProviderInterface implies i != 0) and
-      source = getFlowSourceArg(m, i, sourceAp) and
-      sink = TCallableFlowSinkReturn() and
-      sinkAp = AccessPath::empty() and
-      preservesValue = false
-    )
-  }
-}
-
 /** Data flow for `System.Text.StringBuilder`. */
 class SystemTextStringBuilderFlow extends LibraryTypeDataFlow, SystemTextStringBuilderClass {
-  override predicate callableFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    SourceDeclarationCallable c, boolean preservesValue
-  ) {
-    (
-      this.constructorFlow(source, sourceAp, sink, sinkAp, c) and
-      preservesValue = true
-      or
-      this.methodFlow(source, sourceAp, sink, sinkAp, c, preservesValue)
-    )
-  }
-
-  private predicate constructorFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    Constructor c
-  ) {
-    c = this.getAMember() and
-    c.getParameter(0).getType() instanceof StringType and
-    source = TCallableFlowSourceArg(0) and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::element()
-  }
-
-  private predicate methodFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    SourceDeclarationMethod m, boolean preservesValue
-  ) {
-    exists(string name | m = this.getAMethod() and m.hasUndecoratedName(name) |
-      name = "ToString" and
-      source = TCallableFlowSourceQualifier() and
-      sourceAp = AccessPath::element() and
-      sink = TCallableFlowSinkReturn() and
-      sinkAp = AccessPath::empty() and
-      preservesValue = false
-      or
-      name.regexpMatch("Append(Format|Line|Join)?") and
-      preservesValue = true and
-      (
-        exists(int i, Type t |
-          t = m.getParameter(i).getType() and
-          source = TCallableFlowSourceArg(i) and
-          sink = TCallableFlowSinkQualifier() and
-          sinkAp = AccessPath::element()
-        |
-          (
-            t instanceof StringType or
-            t instanceof ObjectType
-          ) and
-          sourceAp = AccessPath::empty()
-          or
-          isCollectionType(t) and
-          sourceAp = AccessPath::element()
-        )
-        or
-        source = TCallableFlowSourceQualifier() and
-        sourceAp = AccessPath::empty() and
-        sink = TCallableFlowSinkReturn() and
-        sinkAp = AccessPath::empty()
-      )
-    )
-  }
-
   override predicate clearsContent(
     CallableFlowSource source, Content content, SourceDeclarationCallable callable
   ) {
@@ -745,74 +546,6 @@ class SystemTextStringBuilderFlow extends LibraryTypeDataFlow, SystemTextStringB
   }
 }
 
-/** Data flow for `System.Lazy<>`. */
-class SystemLazyFlow extends LibraryTypeDataFlow, SystemLazyClass {
-  override predicate callableFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    SourceDeclarationCallable c, boolean preservesValue
-  ) {
-    preservesValue = true and
-    exists(SystemFuncDelegateType t, int i | t.getNumberOfTypeParameters() = 1 |
-      c.(Constructor).getDeclaringType() = this and
-      c.getParameter(i).getType().getUnboundDeclaration() = t and
-      source = getDelegateFlowSourceArg(c, i) and
-      sourceAp = AccessPath::empty() and
-      sink = TCallableFlowSinkReturn() and
-      sinkAp = AccessPath::property(this.getValueProperty())
-    )
-    or
-    preservesValue = false and
-    c = this.getValueProperty().getGetter() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty()
-  }
-}
-
-/** Data flow for `System.Nullable<>`. */
-class SystemNullableFlow extends LibraryTypeDataFlow, SystemNullableStruct {
-  override predicate callableFlow(
-    CallableFlowSource source, AccessPath sourceAp, CallableFlowSink sink, AccessPath sinkAp,
-    SourceDeclarationCallable c, boolean preservesValue
-  ) {
-    preservesValue = true and
-    c.(Constructor).getDeclaringType() = this and
-    source = getFlowSourceArg(c, 0, sourceAp) and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::property(this.getValueProperty())
-    or
-    preservesValue = true and
-    c = this.getAGetValueOrDefaultMethod() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::property(this.getValueProperty()) and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty()
-    or
-    preservesValue = false and
-    c = this.getHasValueProperty().getGetter() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::property(this.getValueProperty()) and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty()
-    or
-    preservesValue = true and
-    c = this.getAGetValueOrDefaultMethod() and
-    source = getFlowSourceArg(c, 0, _) and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty()
-    or
-    preservesValue = false and
-    c = this.getValueProperty().getGetter() and
-    source = TCallableFlowSourceQualifier() and
-    sourceAp = AccessPath::empty() and
-    sink = TCallableFlowSinkReturn() and
-    sinkAp = AccessPath::empty()
-  }
-}
-
 /** Data flow for `System.Collections.IEnumerable` (and sub types). */
 class IEnumerableFlow extends LibraryTypeDataFlow, RefType {
   IEnumerableFlow() { this.getABaseType*() instanceof SystemCollectionsIEnumerableInterface }
@@ -1597,25 +1330,6 @@ class IDictionaryFlow extends LibraryTypeDataFlow, RefType {
   }
 }
 
-/** Data flow for `System.Convert`. */
-class SystemConvertFlow extends LibraryTypeDataFlow, SystemConvertClass {
-  override predicate callableFlow(
-    CallableFlowSource source, CallableFlowSink sink, SourceDeclarationCallable c,
-    boolean preservesValue
-  ) {
-    this.methodFlow(source, sink, c) and
-    preservesValue = false
-  }
-
-  private predicate methodFlow(
-    CallableFlowSource source, CallableFlowSink sink, SourceDeclarationMethod m
-  ) {
-    m = this.getAMethod() and
-    source = TCallableFlowSourceArg(0) and
-    sink = TCallableFlowSinkReturn()
-  }
-}
-
 /** Data flow for `System.Web.HttpCookie`. */
 class SystemWebHttpCookieFlow extends LibraryTypeDataFlow, SystemWebHttpCookie {
   override predicate callableFlow(