Kotlin: exclude generated code from useless parameter check

tamasvajk · tamasvajk · commit 955336fb222f · 2022-10-12T12:42:56.000+02:00
diff --git a/java/ql/lib/semmle/code/java/deadcode/DeadCode.qll b/java/ql/lib/semmle/code/java/deadcode/DeadCode.qll
@@ -304,6 +304,9 @@ class RootdefCallable extends Callable {
     this.getAnAnnotation() instanceof OverrideAnnotation
     or
     this.hasModifier("override")
+    or
+    // Exclude generated callables, such as `...$default` ones extracted from Kotlin code.
+    this.isCompilerGenerated()
   }
 }
 
diff --git a/java/ql/test/kotlin/query-tests/UselessParameter/UselessParameter.expected b/java/ql/test/kotlin/query-tests/UselessParameter/UselessParameter.expected
@@ -1,2 +1 @@
-| Test.kt:11:1:11:22 | p2 | The parameter 'p2' is never used. |
 | Test.kt:11:8:11:18 | a | The parameter 'a' is never used. |

Original file line number	Diff line number	Diff line change
`@@ -304,6 +304,9 @@ class RootdefCallable extends Callable {`
`304`	`304`	`this.getAnAnnotation() instanceof OverrideAnnotation`
`305`	`305`	`or`
`306`	`306`	`this.hasModifier("override")`
	`307`	`+ or`
	`308`	+ // Exclude generated callables, such as `...$default` ones extracted from Kotlin code.
	`309`	`+ this.isCompilerGenerated()`
`307`	`310`	`}`
`308`	`311`	`}`
`309`	`312`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`		`-\| Test.kt:11:1:11:22 \| p2 \| The parameter 'p2' is never used. \|`
`2`	`1`	`\| Test.kt:11:8:11:18 \| a \| The parameter 'a' is never used. \|`