Swift: remove unused no-parameter constructors

Author: redsun82

swift/codegen/generators/qlgen.py

@@ -279,13 +279,14 @@ def generate(opts, renderer):
         ipa_type = get_ql_ipa_class(cls)
         if ipa_type.is_final:
             final_ipa_types.append(ipa_type)
-            stub_file = stub_out / cls.dir / f"{cls.name}Constructor.qll"
-            if not stub_file.is_file() or _is_generated_stub(stub_file):
-                renderer.render(ql.Synth.ConstructorStub(ipa_type), stub_file)
-            constructor_import = get_import(stub_file, opts.swift_dir)
-            constructor_imports.append(constructor_import)
-            if ipa_type.is_ipa:
-                ipa_constructor_imports.append(constructor_import)
+            if ipa_type.has_params:
+                stub_file = stub_out / cls.dir / f"{cls.name}Constructor.qll"
+                if not stub_file.is_file() or _is_generated_stub(stub_file):
+                    renderer.render(ql.Synth.ConstructorStub(ipa_type), stub_file)
+                constructor_import = get_import(stub_file, opts.swift_dir)
+                constructor_imports.append(constructor_import)
+                if ipa_type.is_ipa:
+                    ipa_constructor_imports.append(constructor_import)
         else:
             non_final_ipa_types.append(ipa_type)
 

swift/ql/lib/codeql/swift/elements/UnknownFileConstructor.qll

@@ -1,4 +1,3 @@
-// generated by codegen/codegen.py, remove this comment if you wish to edit this file
 private import codeql.swift.generated.Raw
 
-predicate constructUnknownLocation() { none() }
+predicate constructUnknownLocation() { any() }

swift/ql/lib/codeql/swift/elements/UnknownLocationConstructor.qll

@@ -1,3 +1,2 @@
+
 // generated by codegen/codegen.py
-import codeql.swift.elements.UnknownFileConstructor
-import codeql.swift.elements.UnknownLocationConstructor

swift/ql/lib/codeql/swift/generated/PureSynthConstructors.qll

@@ -2,8 +2,6 @@
 import codeql.swift.elements.CommentConstructor
 import codeql.swift.elements.DbFileConstructor
 import codeql.swift.elements.DbLocationConstructor
-import codeql.swift.elements.UnknownFileConstructor
-import codeql.swift.elements.UnknownLocationConstructor
 import codeql.swift.elements.decl.AccessorDeclConstructor
 import codeql.swift.elements.decl.AssociatedTypeDeclConstructor
 import codeql.swift.elements.decl.ClassDeclConstructor