C++: Be more optimistic about successfully scanned files.

Author: geoffw0

cpp/ql/src/Diagnostics/SuccessfullyExtractedFiles.ql

@@ -1,16 +1,13 @@
 /**
- * @name Successfully extracted files
- * @description Lists all files in the source code directory that were extracted without encountering a problem in the file.
+ * @name Extracted files
+ * @description Lists all files in the source code directory that were extracted.
  * @kind diagnostic
  * @id cpp/diagnostics/successfully-extracted-files
  * @tags successfully-extracted-files
  */
 
 import cpp
-import ExtractionProblems
 
 from File f
-where
-  not exists(ExtractionProblem e | e.getFile() = f) and
-  exists(f.getRelativePath())
+where exists(f.getRelativePath()) and f.fromSource()
 select f, "File successfully extracted."

cpp/ql/test/query-tests/Diagnostics/SuccessullyExtractedFiles.expected

@@ -1,4 +1,5 @@
 | containserror.cpp:0:0:0:0 | containserror.cpp | File successfully extracted. |
 | containswarning.cpp:0:0:0:0 | containswarning.cpp | File successfully extracted. |
+| doesnotcompile.cpp:0:0:0:0 | doesnotcompile.cpp | File successfully extracted. |
 | header.h:0:0:0:0 | header.h | File successfully extracted. |
 | successful.cpp:0:0:0:0 | successful.cpp | File successfully extracted. |