JS: rename predicate

Author: esbena

javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll

@@ -60,7 +60,7 @@ module AccessPath {
       not this instanceof PropertyProjection and
       not this instanceof Closure::ClosureNamespaceAccess and
       not this = DataFlow::parameterNode(any(ImmediatelyInvokedFunctionExpr iife).getAParameter()) and
-      not this = FlowSteps::IdentityCalls::syntactic(_)
+      not FlowSteps::identityFunctionStep(_, this)
     }
 
     /** Holds if this represents the root of the global access path. */

javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll

@@ -199,7 +199,7 @@ module DataFlow {
         not fun.getExit().isJoin() // can only reach exit by the return statement
       )
       or
-      this = FlowSteps::IdentityCalls::syntactic(result)
+      FlowSteps::identityFunctionStep(result, this)
     }
 
     /**

javascript/ql/src/semmle/javascript/dataflow/internal/FlowSteps.qll

@@ -404,6 +404,18 @@ private module CachedSteps {
   predicate receiverPropWrite(Function f, string prop, DataFlow::Node rhs) {
     DataFlow::thisNode(f).hasPropertyWrite(prop, rhs)
   }
+
+  /**
+   * A step from `pred` to `succ` through a call to an identity function.
+   */
+  cached
+  predicate identityFunctionStep(DataFlow::Node pred, DataFlow::CallNode succ) {
+    exists(DataFlow::GlobalVarRefNode global |
+      global.getName() = "Object" and
+      succ.(DataFlow::MethodCallNode).calls(global, ["freeze", "seal"]) and
+      pred = succ.getArgument(0)
+    )
+  }
 }
 
 import CachedSteps
@@ -529,19 +541,3 @@ module PathSummary {
    */
   PathSummary return() { exists(FlowLabel lbl | result = MkPathSummary(true, false, lbl, lbl)) }
 }
-
-/**
- * Provides predicates for reasoning about calls to identity functions.
- */
-module IdentityCalls {
-  /**
-   * Gets an identity call for `input` that can be recognized syntactically.
-   */
-  DataFlow::CallNode syntactic(DataFlow::Node input) {
-    exists(DataFlow::GlobalVarRefNode global |
-      global.getName() = "Object" and
-      result.(DataFlow::MethodCallNode).calls(global, ["freeze", "seal"]) and
-      input = result.getArgument(0)
-    )
-  }
-}