Python: add comment

yoff · yoff · commit 201c4aad13c5 · 2024-10-04T14:09:33.000+02:00
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll
@@ -368,6 +368,9 @@ abstract class DataFlowFunction extends DataFlowCallable, TFunction {
   int positionalOffset() { result = 0 }
 
   override ParameterNode getParameter(ParameterPosition ppos) {
+    // Do not handle lower bound positions (such as `[1..]`) here
+    // they are handled by parameter matching and would create
+    // inconsistencies here as multiple parameters could match such a position.
     exists(int index | ppos.isPositional(index) |
       result.getParameter() = func.getArg(index + this.positionalOffset())
     )

Original file line number	Diff line number	Diff line change
`@@ -368,6 +368,9 @@ abstract class DataFlowFunction extends DataFlowCallable, TFunction {`
`368`	`368`	`int positionalOffset() { result = 0 }`
`369`	`369`
`370`	`370`	`override ParameterNode getParameter(ParameterPosition ppos) {`
	`371`	+ // Do not handle lower bound positions (such as `[1..]`) here
	`372`	`+ // they are handled by parameter matching and would create`
	`373`	`+ // inconsistencies here as multiple parameters could match such a position.`
`371`	`374`	`exists(int index \| ppos.isPositional(index) \|`
`372`	`375`	`result.getParameter() = func.getArg(index + this.positionalOffset())`
`373`	`376`	`)`