Apply suggestions from code review

tamasvajk · hvitved · web-flow · commit 1d56a8a924e8 · 2024-01-31T09:46:57.000+01:00
Co-authored-by: Tom Hvitved &lt;hvitved@github.com&gt;
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Compilations/Compilation.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Compilations/Compilation.cs
@@ -53,8 +53,7 @@ public override void Populate(TextWriter trapFile)
                         var rspArgs = CommandLineParser.SplitCommandLineIntoArguments(rspFileContent, removeHashComments: true);
                         foreach (var rspArg in rspArgs)
                         {
-                            trapFile.compilation_expanded_args(this, expandedIndex, rspArg);
-                            expandedIndex++;
+                            trapFile.compilation_expanded_args(this, expandedIndex++, rspArg);
                         }
                     }
                     catch (Exception exc)
@@ -64,8 +63,7 @@ public override void Populate(TextWriter trapFile)
                 }
                 else
                 {
-                    trapFile.compilation_expanded_args(this, expandedIndex, arg);
-                    expandedIndex++;
+                    trapFile.compilation_expanded_args(this, expandedIndex++, arg);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,7 @@ public override void Populate(TextWriter trapFile)`
`53`	`53`	`var rspArgs = CommandLineParser.SplitCommandLineIntoArguments(rspFileContent, removeHashComments: true);`
`54`	`54`	`foreach (var rspArg in rspArgs)`
`55`	`55`	`{`
`56`		`- trapFile.compilation_expanded_args(this, expandedIndex, rspArg);`
`57`		`- expandedIndex++;`
	`56`	`+ trapFile.compilation_expanded_args(this, expandedIndex++, rspArg);`
`58`	`57`	`}`
`59`	`58`	`}`
`60`	`59`	`catch (Exception exc)`
`@@ -64,8 +63,7 @@ public override void Populate(TextWriter trapFile)`
`64`	`63`	`}`
`65`	`64`	`else`
`66`	`65`	`{`
`67`		`- trapFile.compilation_expanded_args(this, expandedIndex, arg);`
`68`		`- expandedIndex++;`
	`66`	`+ trapFile.compilation_expanded_args(this, expandedIndex++, arg);`
`69`	`67`	`}`
`70`	`68`	`}`
`71`	`69`