Skip to content

Commit 0675a29

Browse files
committed
Rust: Minor corrections.
1 parent 7a62642 commit 0675a29

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

rust/ql/lib/codeql/rust/security/DisabledCertificateCheckExtensions.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module DisabledCertificateCheckExtensions {
2121
}
2222

2323
/**
24-
* A default sink for disabled certificate check based on function names.
24+
* A default sink for disabled certificate check vulnerabilities based on function names.
2525
*/
2626
private class DefaultSink extends Sink {
2727
DefaultSink() {
@@ -34,7 +34,7 @@ module DisabledCertificateCheckExtensions {
3434
}
3535

3636
/**
37-
* A sink for disabled certificate check from model data.
37+
* A sink for disabled certificate check vulnerabilities from model data.
3838
*/
3939
private class ModelsAsDataSink extends Sink {
4040
ModelsAsDataSink() { sinkNode(this, "disable-certificate") }
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
category: newQuery
33
---
4-
* Added a new query `rust/disabled-certificate-check, to detect disabled TLS certificate checks.
4+
* Added a new query `rust/disabled-certificate-check`, to detect disabled TLS certificate checks.

rust/ql/src/queries/security/CWE-295/DisabledCertificateCheck.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ The <code>danger_accept_invalid_certs</code> and <code>danger_accept_invalid_hos
1111

1212
<recommendation>
1313
<p>
14-
Do not set <code>danger_accept_invalid_certs</code> or <code>danger_accept_invalid_hostnames</code> to <code>true</code> except in controlled environments such as tests. In production, always ensure certificate and hostname verification are enabled to prevent security risks.
14+
Do not set <code>danger_accept_invalid_certs</code> or <code>danger_accept_invalid_hostnames</code> to <code>true</code>, except in controlled environments such as tests. In production, always ensure certificate and hostname verification are enabled to prevent security risks.
1515
</p>
1616
</recommendation>
1717

rust/ql/src/queries/security/CWE-295/DisabledCertificateCheck.ql

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ import codeql.rust.dataflow.DataFlow
1616
import codeql.rust.security.DisabledCertificateCheckExtensions
1717

1818
/**
19-
* A taint configuration for disabling TLS certificate checks.
19+
* A taint configuration for disabled TLS certificate checks.
2020
*/
21-
module LogInjectionConfig implements DataFlow::ConfigSig {
21+
module DisabledCertificateCheckConfig implements DataFlow::ConfigSig {
2222
import DisabledCertificateCheckExtensions
2323

2424
predicate isSource(DataFlow::Node node) {
@@ -30,13 +30,12 @@ module LogInjectionConfig implements DataFlow::ConfigSig {
3030
predicate observeDiffInformedIncrementalMode() { any() }
3131
}
3232

33-
module DisabledCertificateCheckExtensionFlow = DataFlow::Global<LogInjectionConfig>;
33+
module DisabledCertificateCheckFlow = DataFlow::Global<DisabledCertificateCheckConfig>;
3434

35-
import DisabledCertificateCheckExtensionFlow::PathGraph
35+
import DisabledCertificateCheckFlow::PathGraph
3636

3737
from
38-
DisabledCertificateCheckExtensionFlow::PathNode sourceNode,
39-
DisabledCertificateCheckExtensionFlow::PathNode sinkNode
40-
where DisabledCertificateCheckExtensionFlow::flowPath(sourceNode, sinkNode)
38+
DisabledCertificateCheckFlow::PathNode sourceNode, DisabledCertificateCheckFlow::PathNode sinkNode
39+
where DisabledCertificateCheckFlow::flowPath(sourceNode, sinkNode)
4140
select sinkNode.getNode(), sourceNode, sinkNode,
4241
"Disabling TLS certificate validation can expose the application to man-in-the-middle attacks."

0 commit comments

Comments
 (0)