Remove redundant Read and Write method models

Author: gagliardetto

ql/src/semmle/go/frameworks/stdlib/CryptoCipher.qll

@@ -11,14 +11,6 @@ module CryptoCipher {
     FunctionOutput outp;
 
     MethodModels() {
-      // signature: func (StreamReader).Read(dst []byte) (n int, err error)
-      this.hasQualifiedName("crypto/cipher", "StreamReader", "Read") and
-      (inp.isReceiver() and outp.isParameter(0))
-      or
-      // signature: func (StreamWriter).Write(src []byte) (n int, err error)
-      this.hasQualifiedName("crypto/cipher", "StreamWriter", "Write") and
-      (inp.isParameter(0) and outp.isReceiver())
-      or
       // signature: func (Block).Decrypt(dst []byte, src []byte)
       this.implements("crypto/cipher", "Block", "Decrypt") and
       (inp.isParameter(1) and outp.isParameter(0))

ql/src/semmle/go/frameworks/stdlib/CryptoTls.qll

@@ -36,23 +36,4 @@ module CryptoTls {
       input = inp and output = outp
     }
   }
-
-  private class MethodModels extends TaintTracking::FunctionModel, Method {
-    FunctionInput inp;
-    FunctionOutput outp;
-
-    MethodModels() {
-      // signature: func (*Conn).Read(b []byte) (int, error)
-      this.hasQualifiedName("crypto/tls", "Conn", "Read") and
-      (inp.isReceiver() and outp.isParameter(0))
-      or
-      // signature: func (*Conn).Write(b []byte) (int, error)
-      this.hasQualifiedName("crypto/tls", "Conn", "Write") and
-      (inp.isParameter(0) and outp.isReceiver())
-    }
-
-    override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {
-      input = inp and output = outp
-    }
-  }
 }