Exclude boolean literals used as non-type template arguments

Author: rvermeulen

cpp/autosar/src/rules/A5-1-1/LiteralValueUsedOutsideTypeInit.ql

@@ -39,7 +39,7 @@ where
   // Exclude `nullptr`
   not l.getType() instanceof NullPointerType and
   // Exclude boolean `true` and `false`
-  not l.getType() instanceof BoolType and
+  not l instanceof BoolLiteral and
   // Exclude empty string
   not l.getValue() = "" and
   // Template functions use literals to represent calls which are unknown

cpp/common/src/codingstandards/cpp/Literals.qll

@@ -47,3 +47,15 @@ class CompileTimeComputedIntegralLiteral extends Literal {
     not any(ConstructorFieldInit cfi).getExpr() = this
   }
 }
+
+class BoolLiteral extends Literal {
+  BoolLiteral() {
+    this.getType() instanceof BoolType
+    or
+    // When used as non-type template arguments, bool literals might
+    // have been converted to a non-bool type.
+    this.getValue() = "1" and this.getValueText() = "true"
+    or
+    this.getValue() = "0" and this.getValueText() = "false"
+  }
+}