First implementation of Rule 22-3-1

Author: MichaelRFairhurst

c/cert/src/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

c/cert/test/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

c/common/src/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

c/common/test/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

cpp/autosar/src/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

cpp/autosar/test/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

cpp/cert/src/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

cpp/cert/test/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

cpp/common/src/codeql-pack.lock.yml

@@ -1,6 +1,8 @@
 ---
 lockVersion: 1.0.0
 dependencies:
+  advanced-security/qtil:
+    version: 0.0.3
   codeql/cpp-all:
     version: 4.0.3
   codeql/dataflow:

cpp/common/src/codingstandards/cpp/ast/Conditions.qll

@@ -0,0 +1,29 @@
+import cpp
+import codeql.util.Boolean
+
+/**
+ * Any type of conditional evaluation, such as if statements, and conditional expressions.
+ *
+ * A condition may be:
+ * - An if statement condition
+ * - A conditional expression (ternary) condition
+ * - A short-circuiting logical expression (&& or ||)
+ */
+class Conditional extends Element {
+  Expr condition;
+
+  Conditional() {
+    condition = this.(ConditionalExpr).getCondition()
+    or
+    condition = this.(IfStmt).getCondition()
+    or
+    condition = this.(LogicalOrExpr).getLeftOperand()
+    or
+    condition = this.(LogicalAndExpr).getLeftOperand()
+  }
+
+  /**
+   * Get the expression that controls the flow of this conditional.
+   */
+  Expr getCondition() { result = condition }
+}