Do not mutate originalUserInput

Author: mbg

lib/init-action.js

@@ -197,20 +197,18 @@ test("load code quality config", async (t) => {
       }),
     );
 
-    const userConfig: configUtils.UserConfig = {
-      "disable-default-queries": true,
-      queries: [{ uses: "code-quality" }],
-      "query-filters": [],
-    };
-
     // And the config we expect it to result in
     const expectedConfig: configUtils.Config = {
       analysisKinds: [AnalysisKind.CodeQuality],
       languages: [KnownLanguage.actions],
       buildMode: undefined,
+      originalUserInput: {},
       // This gets set because we only have `AnalysisKind.CodeQuality`
-      originalUserInput: userConfig,
-      computedConfig: userConfig,
+      computedConfig: {
+        "disable-default-queries": true,
+        queries: [{ uses: "code-quality" }],
+        "query-filters": [],
+      },
       tempDir,
       codeQLCmd: codeql.getPath(),
       gitHubVersion: githubVersion,

src/config-utils.test.ts

@@ -1145,11 +1145,6 @@ export async function initConfig(inputs: InitConfigInputs): Promise<Config> {
     const queries = codeQualityQueries.map((v) => ({ uses: v }));
 
     // Set the query customisation options for Code Quality only analysis.
-    config.originalUserInput["disable-default-queries"] = true;
-    config.originalUserInput.queries = queries;
-    config.originalUserInput["query-filters"] = [];
-
-    // Update the computed configuration for the call to `getOverlayDatabaseMode`.
     config.computedConfig["disable-default-queries"] = true;
     config.computedConfig.queries = queries;
     config.computedConfig["query-filters"] = [];