Skip to content

Commit 8a3bfe6

Browse files
committed
Transpile separately in both build and test steps
This means we avoid doing a type checking pass twice
1 parent 4da503e commit 8a3bfe6

18 files changed

+96
-112
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Dependency directories
22
node_modules/
33
# Build output for tests
4-
lib-test/
4+
build/
55
# Java build files
66
.gradle/
77
*.class

.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"**/.DS_Store": true,
66

77
// transpiled JavaScript
8+
"build": true,
89
"lib": true,
9-
"lib-test": true,
1010
},
1111
// Installing a new Node package often triggers VS Code's git limit warnings as there is typically
1212
// an intermediate stage where many files are modified. This setting suppresses these warnings.

build.mjs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { fileURLToPath } from "node:url";
55
import * as esbuild from "esbuild";
66
import { globSync } from "glob";
77
import { copy } from "esbuild-plugin-copy";
8-
import { typecheckPlugin } from "@jgoz/esbuild-plugin-typecheck";
98

109
const __filename = fileURLToPath(import.meta.url);
1110
const __dirname = dirname(__filename);
@@ -39,7 +38,7 @@ const context = await esbuild.context({
3938
format: "cjs",
4039
outdir: OUT_DIR,
4140
platform: "node",
42-
plugins: [typecheckPlugin(), copyDefaults, onEndPlugin],
41+
plugins: [copyDefaults, onEndPlugin],
4342
});
4443

4544
await context.rebuild();

eslint.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ export default [
2626
{
2727
ignores: [
2828
"**/webpack.config.js",
29+
"build/**/*",
2930
"lib/**/*",
30-
"lib-test/**/*",
3131
"src/testdata/**/*",
3232
"tests/**/*",
3333
"build.mjs",

lib/analyze-action-post.js

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/analyze-action.js

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/autobuild-action.js

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action-post.js

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/init-action.js

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/resolve-environment-action.js

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)