kit: advanced commit view controller search field bugs have been fixed.

Author: lolgear

GitUpKit/Views/Base.lproj/GIAdvancedCommitViewController.xib

@@ -146,9 +146,6 @@
                                                                                 <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
                                                                                 <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
                                                                             </searchFieldCell>
-                                                                            <connections>
-                                                                                <outlet property="nextKeyView" destination="ZGk-oR-MNP" id="iik-md-9MI"/>
-                                                                            </connections>
                                                                         </searchField>
                                                                     </subviews>
                                                                     <constraints>

GitUpKit/Views/GIAdvancedCommitViewController.m

@@ -50,7 +50,7 @@ @implementation GIAdvancedCommitViewController {
 
 #pragma mark - Search
 - (void)setupSearch {
-  [NSNotificationCenter.defaultCenter addObserver:self selector:@selector(textDidChange:) name:NSTextDidChangeNotification object:nil];
+  self.searchTextField.delegate = self;
   self.searchTextField.nextKeyView = self.messageTextView;
   self.searchTextField.nextResponder = self.messageTextView;
 }
@@ -60,17 +60,16 @@ - (void)resetSearch {
   [self.repository updateFilePattern:nil];
 }
 
-- (void)unsetSearch {
-  [NSNotificationCenter.defaultCenter removeObserver:self];
-}
-
-- (void)textDidChange:(NSNotification *)notification {
-  NSString *text = self.searchTextField.stringValue;
-  if ([@"" isEqualToString:text]) {
-    [self.repository updateFilePattern:nil];
-  }
-  else {
-    [self.repository updateFilePattern:text];
+#pragma mark - NSControlTextEditingDelegate
+- (void)controlTextDidChange:(NSNotification *)obj {
+  if (obj.object == self.searchTextField) {
+    NSString *text = self.searchTextField.stringValue;
+    if ([@"" isEqualToString:text]) {
+      [self.repository updateFilePattern:nil];
+    }
+    else {
+      [self.repository updateFilePattern:text];
+    }
   }
 }
 
@@ -131,10 +130,6 @@ - (void)viewWillDisappear {
   [self resetSearch];
 }
 
-- (void)dealloc {
-  [self unsetSearch];
-}
-
 #pragma mark - Repository Handling
 - (void)repositoryStatusDidUpdate {
   [super repositoryStatusDidUpdate];