From 5f7e3de63a10ebd366f4f8c4b8b80318b8f913a0 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Mon, 11 Nov 2024 16:51:39 +0100 Subject: [PATCH] installer: do not try to terminate/restart apps under /CLOSEAPPLICATIONS When `/CLOSEAPPLICATIONS` or `/FORCECLOSEAPPLICATIONS` is passed to InnoSetup, it will handle the closing/terminating of in-use apps, and we do not have to do anything manually. This fixes https://github.com/git-for-windows/git/issues/5250 Signed-off-by: Johannes Schindelin --- installer/install.iss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/installer/install.iss b/installer/install.iss index 77dd988acd..38fd0fdf40 100644 --- a/installer/install.iss +++ b/installer/install.iss @@ -678,7 +678,7 @@ var Caption:String; ManualClosingRequired:Boolean; begin - if (AppDir='') then begin + if (AppDir='') or (Pos('/CLOSEAPPLICATIONS',UpperCase(GetCmdTail))>0) or (Pos('/FORCECLOSEAPPLICATIONS',UpperCase(GetCmdTail))>0) then begin SetArrayLength(Processes,0); Exit; end;