-
Notifications
You must be signed in to change notification settings - Fork 55
Open
Labels
Description
Describe the bug
When following instructions in the README, after freshly cloning a copy of this repo, when trying to bun i in this client directory, I get the following:
bun install v1.1.4 (fbe2fe0c)
⚙️ cypress [7/11] CXX(target) Release/obj.target/pty/src/unix/pty.o
...<snip>...
2 warnings and 2 errors generated.
make: *** [Release/obj.target/pty/src/unix/pty.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Users/chrisdotcode/home/code/gingko/client/node_modules/node-gyp/lib/build.js:203:23)
gyp ERR! stack at ChildProcess.emit (node:events:520:28)
gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:294:12)
gyp ERR! System Darwin 24.1.0
gyp ERR! command "/opt/homebrew/Cellar/node/22.8.0/bin/node" "/Users/chrisdotcode/home/code/gingko/client/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /Users/chrisdotcode/home/code/gingko/client/node_modules/node-pty
gyp ERR! node -v v22.8.0
gyp ERR! node-gyp -v v9.3.0
gyp ERR! not ok
error: install script from "node-pty" exited with 1To Reproduce
- Clone the repo
- cd
client/ - Run
bun i
Expected behavior
The installation to be successful.
Software info:
- OS: macOS 15.11
- Gingko Version: N/A
Additional context
I believe this may be an issue on the bun side, cf. microsoft/node-pty#632, which leads to oven-sh/bun#4290. However, I presume that this worked at some point in the past, and my best guess as to why it's not working now is that npm install was used before at some point before the switch to bun, and so whomever already had a working copy of node-pty in node_modules before the bun switch kept it, and didn't get a chance to test install dependencies with bun itself.