Skip to content

chore(top-issues): add more actions #104467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvxluo merged 3 commits into from
Dec 8, 2025
+98 −6
Merged

chore(top-issues): add more actions #104467

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6121f89
feat: scaffold for new buttons
cvxluo Dec 5, 2025
b1b395f
feat: functional buttons
cvxluo Dec 5, 2025
72b7e70
feat: add collapse summary
cvxluo Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 98 additions & 6 deletions static/app/views/issueList/pages/dynamicGrouping.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import {Fragment, useMemo, useState} from 'react';
import {Fragment, useCallback, useMemo, useState} from 'react';
import styled from '@emotion/styled';

import {Tag} from '@sentry/scraps/badge';
import {Container, Flex} from '@sentry/scraps/layout';
import {Heading, Text} from '@sentry/scraps/text';

import {bulkUpdate} from 'sentry/actionCreators/group';
import {openConfirmModal} from 'sentry/components/confirm';
import {Button} from 'sentry/components/core/button';
import {ButtonBar} from 'sentry/components/core/button/buttonBar';
import {Checkbox} from 'sentry/components/core/checkbox';
Expand All @@ -31,6 +33,7 @@ import {
IconClock,
IconClose,
IconCopy,
IconEllipsis,
IconFire,
IconFix,
IconSeer,
Expand All @@ -40,8 +43,10 @@ import {
import {t, tn} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import type {Group} from 'sentry/types/group';
import {GroupStatus, GroupSubstatus} from 'sentry/types/group';
import {getMessage, getTitle} from 'sentry/utils/events';
import {useApiQuery} from 'sentry/utils/queryClient';
import useApi from 'sentry/utils/useApi';
import useCopyToClipboard from 'sentry/utils/useCopyToClipboard';
import useOrganization from 'sentry/utils/useOrganization';
import usePageFilters from 'sentry/utils/usePageFilters';
Expand Down Expand Up @@ -361,7 +366,9 @@ function ClusterCard({
onTagClick?: (tag: string) => void;
selectedTags?: Set<string>;
}) {
const api = useApi();
const organization = useOrganization();
const {selection} = usePageFilters();
const [showDescription, setShowDescription] = useState(false);
const clusterStats = useClusterStats(cluster.group_ids);
const {copy} = useCopyToClipboard();
Expand All @@ -379,9 +386,64 @@ function ClusterCard({
copy(formatClusterInfoForClipboard(cluster));
};

const handleResolve = useCallback(() => {
openConfirmModal({
header: t('Resolve All Issues in Cluster'),
message: t(
'Are you sure you want to resolve all %s issues in this cluster?.',
cluster.group_ids.length
),
confirmText: t('Resolve All'),
onConfirm: () => {
bulkUpdate(
api,
{
orgId: organization.slug,
itemIds: cluster.group_ids.map(String),
data: {status: GroupStatus.RESOLVED},
project: selection.projects,
environment: selection.environments,
...selection.datetime,
},
{}
);
},
});
}, [api, cluster.group_ids, organization.slug, selection]);

const handleArchive = useCallback(() => {
openConfirmModal({
header: t('Archive All Issues in Cluster'),
message: t(
'Are you sure you want to archive all %s issues in this cluster?.',
cluster.group_ids.length
),
confirmText: t('Archive All'),
onConfirm: () => {
bulkUpdate(
api,
{
orgId: organization.slug,
itemIds: cluster.group_ids.map(String),
data: {
status: GroupStatus.IGNORED,
statusDetails: {},
substatus: GroupSubstatus.ARCHIVED_UNTIL_ESCALATING,
},
project: selection.projects,
environment: selection.environments,
...selection.datetime,
},
{}
);
},
});
}, [api, cluster.group_ids, organization.slug, selection]);
Comment on lines +431 to +441
Copy link

@sentry sentry bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Bulk resolve/archive operations ignore date filters because query parameter is missing when selection.datetime is passed to bulkUpdate.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

The bulkUpdate calls within handleResolve and handleArchive in dynamicGrouping.tsx pass selection.datetime but omit the query parameter. The internal paramsToQueryArgs function, which processes these parameters, only includes date filters (start, end, period, utc) when a query parameter is present. As a result, the user's selected date range filters will be ignored, causing bulk resolve and archive operations to apply to all issues in the cluster, rather than only those within the specified date range. This leads to operations affecting more issues than the user intended.

💡 Suggested Fix

Ensure handleResolve and handleArchive pass a query parameter (e.g., selection.query) along with selection.datetime to bulkUpdate to enable date filter application.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/issueList/pages/dynamicGrouping.tsx#L389-L441

Potential issue: The `bulkUpdate` calls within `handleResolve` and `handleArchive` in
`dynamicGrouping.tsx` pass `selection.datetime` but omit the `query` parameter. The
internal `paramsToQueryArgs` function, which processes these parameters, only includes
date filters (`start`, `end`, `period`, `utc`) when a `query` parameter is present. As a
result, the user's selected date range filters will be ignored, causing bulk resolve and
archive operations to apply to all issues in the cluster, rather than only those within
the specified date range. This leads to operations affecting more issues than the user
intended.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5888438


const handleDismiss = () => {};

return (
<CardContainer>
{/* Zone 1: Title + Description (Primary Focus) */}
<CardHeader>
<ClusterTitle>{renderWithInlineCode(cluster.title)}</ClusterTitle>
<ClusterTags
Expand All @@ -392,7 +454,12 @@ function ClusterCard({
{cluster.description && (
<Fragment>
{showDescription ? (
<DescriptionText>{cluster.description}</DescriptionText>
<Fragment>
<DescriptionText>{cluster.description}</DescriptionText>
<ReadMoreButton onClick={() => setShowDescription(false)}>
{t('Collapse summary')}
</ReadMoreButton>
</Fragment>
) : (
<ReadMoreButton onClick={() => setShowDescription(true)}>
{t('View summary')}
Expand All @@ -402,7 +469,6 @@ function ClusterCard({
)}
</CardHeader>

{/* Zone 2: Stats (Secondary Context) */}
<ClusterStatsBar>
{cluster.fixability_score !== null && cluster.fixability_score !== undefined && (
<StatItem>
Expand Down Expand Up @@ -469,7 +535,6 @@ function ClusterCard({
)}
</ClusterStatsBar>

{/* Zone 3: Nested Issues (Detail Content) */}
<IssuesSection>
<IssuesSectionHeader>
<Text size="sm" bold uppercase>
Expand All @@ -481,7 +546,6 @@ function ClusterCard({
</IssuesList>
</IssuesSection>

{/* Zone 4: Actions (Tertiary) */}
<CardFooter>
<ButtonBar merged gap="0">
<SeerButton
Expand Down Expand Up @@ -520,6 +584,34 @@ function ClusterCard({
{t('View All Issues') + ` (${cluster.group_ids.length})`}
</Button>
</Link>
<DropdownMenu
items={[
{
key: 'resolve',
label: t('Resolve All'),
onAction: handleResolve,
},
{
key: 'archive',
label: t('Archive All'),
onAction: handleArchive,
},
{
key: 'dismiss',
label: t('Dismiss'),
onAction: handleDismiss,
},
]}
trigger={triggerProps => (
<Button
{...triggerProps}
size="sm"
icon={<IconEllipsis size="sm" />}
aria-label={t('More actions')}
/>
)}
position="bottom-end"
/>
</CardFooter>
</CardContainer>
);
Expand Down
Loading