fix(usage overview): Display add-on categories with reserved volume #104465
+343
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 13 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ).flatMap(addOnInfo => addOnInfo.dataCategories); | ||
| const addOnDataCategories = Object.values(subscription.planDetails.addOnCategories) | ||
| .flatMap(addOnInfo => addOnInfo.dataCategories) | ||
| .filter(category => checkIsAddOnChildCategory(subscription, category, true)); |
Contributor
There was a problem hiding this comment.
Bug: Categories with zero reserved hidden when add-on has mixed values
When an add-on has multiple data categories with mixed reserved values (some with non-zero reserved volume, some with zero), categories with zero reserved become invisible. This happens because: (1) zero-reserved categories are added to addOnDataCategories and filtered out of the main list, (2) but the add-on section returns null when ANY sub-category has non-zero reserved. The comment on line 89-90 claims these categories will render in sortedCategories, but this only applies to categories that fail checkIsAddOnChildCategory - zero-reserved categories pass the check and get excluded from both locations.
Additional Locations (1)
Member
Author
There was a problem hiding this comment.
documenting assumption for now since we don't currently support a mix
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
+128
to
138
| isChildProduct | ||
| parentProduct={apiName} | ||
| usageData={usageData} | ||
| organization={organization} | ||
| /> | ||
| ); | ||
| }) | ||
| : null} | ||
| </Fragment> | ||
| ); | ||
| })} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where we didn't display add-on sub-categories that had a non-reserved budget / non-unlimited volume: