Skip to content

Commit 905a502

Browse files
authored
fix(tracemetrics): Improve metrics analytics (#104495)
This elides metric counts when the metric name is empty, and improves testing around metric panel etc.
1 parent 4532453 commit 905a502

File tree

6 files changed

+395
-130
lines changed

6 files changed

+395
-130
lines changed

static/app/utils/analytics/metricsAnalyticsEvent.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,21 @@ export type MetricsAnalyticsEventParameters = {
1111
metric_panels_with_group_bys_count: number;
1212
metric_queries_count: number;
1313
project_count: number;
14+
title: string;
1415
};
1516
'metrics.explorer.panel.metadata': {
16-
columns: readonly string[];
17-
columns_count: number;
17+
aggregate_function: string;
1818
confidences: string[];
1919
dataScanned: string;
2020
dataset: string;
2121
empty_buckets_percentage: number[];
22+
group_bys: readonly string[];
2223
interval: string;
24+
metric_name: string;
25+
metric_type: string;
2326
query_status: 'success' | 'error' | 'pending';
2427
sample_counts: number[];
2528
table_result_length: number;
26-
table_result_missing_root: number;
2729
table_result_mode: 'metric samples' | 'aggregates';
2830
table_result_sort: string[];
2931
user_queries: string;

0 commit comments

Comments
 (0)