Commit 47e1580
authored
fix(profiling): Maximum update depth exceeded error on flamegraphs (#104544)
Not sure why but when clicking around the flamegraphs, sometimes,
`location.query` updates a lot and this causes the options menu to hit a
maximum update depth exceeded error. Instead of depending on
`location.query`, depend on the values, which are strings, directly so
there are fewer updates.
Fixes JAVASCRIPT-34VQ1 parent 46c3eb2 commit 47e1580
File tree
1 file changed
+12
-3
lines changed- static/app/components/profiling/flamegraph/flamegraphToolbar
1 file changed
+12
-3
lines changedLines changed: 12 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
| 49 | + | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
64 | 73 | | |
65 | 74 | | |
66 | 75 | | |
| |||
0 commit comments