Fail gracefully when Raven isnt configured

Author: dcramer

src/raven.js

@@ -231,6 +231,10 @@ var Raven = {
      * @return {Raven}
      */
     captureException: function(ex, options) {
+        if (!isSetup()) {
+            return Raven;
+        }
+
         // If not an Error is passed through, recall as a message instead
         if (!isError(ex)) return Raven.captureMessage(ex, options);
 
@@ -262,6 +266,10 @@ var Raven = {
      * @return {Raven}
      */
     captureMessage: function(msg, options) {
+        if (!isSetup()) {
+            return Raven;
+        }
+
         // config() automagically converts ignoreErrors from a list to a RegExp so we need to test for an
         // early call; we'll error on the side of logging anything called before configuration since it's
         // probably something you should see:

test/raven.test.js

@@ -1680,17 +1680,21 @@ describe('Raven (public API)', function() {
 
     describe('.captureMessage', function() {
         it('should work as advertised', function() {
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'send');
             Raven.captureMessage('lol', {foo: 'bar'});
+            assert.isTrue(window.send.called);
             assert.deepEqual(window.send.lastCall.args, [{
                 message: 'lol',
                 foo: 'bar'
             }]);
         });
 
         it('should coerce message to a string', function() {
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'send');
             Raven.captureMessage({});
+            assert.isTrue(window.send.called);
             assert.deepEqual(window.send.lastCall.args, [{
                 message: '[object Object]'
             }]);
@@ -1716,6 +1720,7 @@ describe('Raven (public API)', function() {
         });
 
         it('should respect `ignoreErrors`', function() {
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'send');
 
             globalOptions.ignoreErrors = joinRegExp(['e1', 'e2']);
@@ -1726,25 +1731,36 @@ describe('Raven (public API)', function() {
             Raven.captureMessage('Non-ignored error');
             assert.isTrue(window.send.calledOnce);
         });
+
+        it('should not throw an error if not configured', function() {
+            this.sinon.stub(Raven, 'isSetup').returns(false);
+            this.sinon.stub(window, 'send')
+            Raven.captureMessage('foo');
+            assert.isFalse(window.send.called);
+        });
+
     });
 
     describe('.captureException', function() {
         it('should call handleStackInfo', function() {
             var error = new Error('crap');
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'handleStackInfo');
             Raven.captureException(error, {foo: 'bar'});
             assert.isTrue(window.handleStackInfo.calledOnce);
         });
 
         it('should store the last exception', function() {
             var error = new Error('crap');
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'handleStackInfo');
             Raven.captureException(error);
             assert.equal(Raven.lastException(), error);
         });
 
-        it('shouldn\'t reraise the if the error is the same error', function() {
+        it('shouldn\'t reraise the if error is the same error', function() {
             var error = new Error('crap');
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'handleStackInfo').throws(error);
             // this would raise if the errors didn't match
             Raven.captureException(error, {foo: 'bar'});
@@ -1753,22 +1769,33 @@ describe('Raven (public API)', function() {
 
         it('should reraise a different error', function() {
             var error = new Error('crap1');
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(window, 'handleStackInfo').throws(error);
             assert.throws(function() {
                 Raven.captureException(new Error('crap2'));
             }, error);
         });
 
         it('should capture as a normal message if a non-Error is passed', function() {
+            this.sinon.stub(window, 'isSetup').returns(true);
             this.sinon.stub(Raven, 'captureMessage');
             this.sinon.stub(window, 'handleStackInfo')
             Raven.captureException('derp');
+            assert.isTrue(Raven.captureMessage.called);
             assert.equal(Raven.captureMessage.lastCall.args[0], 'derp');
             assert.isFalse(window.handleStackInfo.called);
             Raven.captureException(true);
+            assert.isTrue(Raven.captureMessage.called);
             assert.equal(Raven.captureMessage.lastCall.args[0], true);
             assert.isFalse(window.handleStackInfo.called);
         });
+
+        it('should not throw an error if not configured', function() {
+            this.sinon.stub(Raven, 'isSetup').returns(false);
+            this.sinon.stub(window, 'handleStackInfo')
+            Raven.captureException(new Error('err'));
+            assert.isFalse(window.handleStackInfo.called);
+        });
     });
 
     describe('.isSetup', function() {