Skip to content

Commit aa38e37

Browse files
authored
test(profiling-node): Ensure E2E tests run for profiling-node (#15248)
This test was still skipped. I un-skipped it and actually split this up into dedicated tests for clarity. Can't get electron to run successfully on CI (works locally for me...) so skipping it for now, until maybe @timfish can figure it out :D
1 parent 3e31bdc commit aa38e37

File tree

19 files changed

+103
-29
lines changed

19 files changed

+103
-29
lines changed

dev-packages/e2e-tests/test-applications/node-profiling/.gitignore renamed to dev-packages/e2e-tests/test-applications/node-profiling-cjs/.gitignore

File renamed without changes.

dev-packages/e2e-tests/test-applications/node-profiling/.npmrc renamed to dev-packages/e2e-tests/test-applications/node-profiling-cjs/.npmrc

File renamed without changes.

dev-packages/e2e-tests/test-applications/node-profiling/build-cjs.mjs renamed to dev-packages/e2e-tests/test-applications/node-profiling-cjs/build-cjs.mjs

File renamed without changes.

dev-packages/e2e-tests/test-applications/node-profiling/index.ts renamed to dev-packages/e2e-tests/test-applications/node-profiling-cjs/index.ts

File renamed without changes.
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
{
2+
"name": "node-profiling-cjs",
3+
"version": "1.0.0",
4+
"private": true,
5+
"scripts": {
6+
"typecheck": "tsc --noEmit",
7+
"test": "node dist/cjs/index.js",
8+
"clean": "npx rimraf node_modules dist",
9+
"test:build": "pnpm install && node build-cjs.mjs",
10+
"test:assert": "pnpm run typecheck && pnpm run test"
11+
},
12+
"dependencies": {
13+
"@playwright/test": "~1.50.0",
14+
"@sentry/node": "latest || *",
15+
"@sentry/profiling-node": "latest || *",
16+
"esbuild": "0.20.0",
17+
"typescript": "^5.7.3"
18+
},
19+
"volta": {
20+
"extends": "../../package.json"
21+
}
22+
}

dev-packages/e2e-tests/test-applications/node-profiling/tsconfig.json renamed to dev-packages/e2e-tests/test-applications/node-profiling-cjs/tsconfig.json

File renamed without changes.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
dist
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# @sentry:registry=http://127.0.0.1:4873
2+
# @sentry-internal:registry=http://127.0.0.1:4873

dev-packages/e2e-tests/test-applications/node-profiling/__tests__/electron.spec.js renamed to dev-packages/e2e-tests/test-applications/node-profiling-electron/__tests__/electron.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ test('an h1 contains hello world"', async () => {
77
process: {
88
env: {
99
...process.env,
10+
NODE_ENV: 'development',
1011
},
1112
},
1213
});

dev-packages/e2e-tests/test-applications/node-profiling/index.electron.js renamed to dev-packages/e2e-tests/test-applications/node-profiling-electron/index.electron.js

File renamed without changes.

0 commit comments

Comments
 (0)