fix: Make event processor sync

Author: HazAT

packages/core/src/base.ts

@@ -242,10 +242,6 @@ export abstract class BaseClient<B extends Backend, O extends Options>
       prepared.release = release;
     }
 
-    if (scope) {
-      scope.applyToEvent(prepared, Math.min(maxBreadcrumbs, MAX_BREADCRUMBS));
-    }
-
     if (prepared.message) {
       prepared.message = truncate(prepared.message, MAX_URL_LENGTH);
     }
@@ -265,6 +261,12 @@ export abstract class BaseClient<B extends Backend, O extends Options>
 
     prepared.event_id = uuid4();
 
+    // This should be the last thing called, since we want that
+    // {@link Hub.addEventProcessor} gets the finished prepared event.
+    if (scope) {
+      scope.applyToEvent(prepared, Math.min(maxBreadcrumbs, MAX_BREADCRUMBS));
+    }
+
     return prepared;
   }
 

packages/core/src/sdk.ts

@@ -27,6 +27,10 @@ export function initAndBind<F extends Client, O extends Options>(
   const client = new clientClass(options);
   client.install();
 
+  // This should happen here if any integration uses {@link Hub.addEventProcessor}
+  // there needs to be a client on the hub already.
+  getDefaultHub().bindClient(client);
+
   let integrations = [...defaultIntegrations];
   if (Array.isArray(options.integrations)) {
     integrations = [...integrations, ...options.integrations];
@@ -40,6 +44,4 @@ export function initAndBind<F extends Client, O extends Options>(
       integration.install();
     });
   }
-
-  getDefaultHub().bindClient(client);
 }

packages/hub/src/scope.ts

@@ -8,9 +8,6 @@ export class Scope {
   /** Flag if notifiying is happening. */
   protected notifyingListeners: boolean = false;
 
-  /** Flag if notifiying is happening. */
-  protected notifyingProcessors: boolean = false;
-
   /** Callback for client to receive scope changes. */
   protected scopeListeners: Array<(scope: Scope) => void> = [];
 
@@ -61,15 +58,9 @@ export class Scope {
    * This will be called after {@link applyToEvent} is finished.
    */
   protected notifyEventProcessors(event: SentryEvent): void {
-    if (!this.notifyingProcessors) {
-      this.notifyingProcessors = true;
-      setTimeout(() => {
-        this.eventProcessors.forEach(callback => {
-          callback(event);
-        });
-        this.notifyingProcessors = false;
-      }, 0);
-    }
+    this.eventProcessors.forEach(callback => {
+      callback(event);
+    });
   }
 
   /**

packages/hub/test/lib/hub.test.ts

@@ -227,8 +227,7 @@ describe('Hub', () => {
   });
 
   test('addEventProcessor', done => {
-    jest.useFakeTimers();
-    expect.assertions(1);
+    expect.assertions(2);
     const event: SentryEvent = {
       extra: { b: 3 },
     };
@@ -237,9 +236,14 @@ describe('Hub', () => {
     const hub = new Hub({ a: 'b' }, localScope);
     hub.addEventProcessor(() => (processedEvent: SentryEvent) => {
       expect(processedEvent.extra).toEqual({ a: 'b', b: 3 });
+    });
+    hub.addEventProcessor(() => (processedEvent: SentryEvent) => {
+      processedEvent.dist = '1';
+    });
+    hub.addEventProcessor(() => (processedEvent: SentryEvent) => {
+      expect(processedEvent.dist).toEqual('1');
       done();
     });
     localScope.applyToEvent(event);
-    jest.runAllTimers();
   });
 });