File tree Expand file tree Collapse file tree 5 files changed +6
-0
lines changed
replay-internal/src/coreHandlers/util Expand file tree Collapse file tree 5 files changed +6
-0
lines changed Original file line number Diff line number Diff line change @@ -27,6 +27,7 @@ export function getDefaultIntegrations(options: CloudflareOptions): Integration[
2727 functionToStringIntegration ( ) ,
2828 linkedErrorsIntegration ( ) ,
2929 fetchIntegration ( ) ,
30+ // TODO(v10): the `include` object should be defined directly in the integration based on `sendDefaultPii`
3031 requestDataIntegration ( sendDefaultPii ? undefined : { include : { cookies : false } } ) ,
3132 consoleIntegration ( ) ,
3233 ] ;
Original file line number Diff line number Diff line change @@ -21,6 +21,7 @@ type RequestDataIntegrationOptions = {
2121 include ?: RequestDataIncludeOptions ;
2222} ;
2323
24+ // TODO(v10): Change defaults based on `sendDefaultPii`
2425const DEFAULT_INCLUDE : RequestDataIncludeOptions = {
2526 cookies : true ,
2627 data : true ,
Original file line number Diff line number Diff line change @@ -61,6 +61,7 @@ const _nodeContextIntegration = ((options: ContextOptions = {}) => {
6161
6262 const updatedContext = _updateContext ( await cachedContext ) ;
6363
64+ // TODO(v10): conditional with `sendDefaultPii` here?
6465 event . contexts = {
6566 ...event . contexts ,
6667 app : { ...updatedContext . app , ...event . contexts ?. app } ,
Original file line number Diff line number Diff line change @@ -98,6 +98,8 @@ function _prepareXhrData(
9898 } ;
9999 }
100100
101+ // ---- This additional network data below is only captured for URLs defined in `networkDetailAllowUrls` ----
102+
101103 const xhrInfo = xhr [ SENTRY_XHR_DATA_KEY ] ;
102104 const networkRequestHeaders = xhrInfo
103105 ? getAllowedHeaders ( xhrInfo . request_headers , options . networkRequestHeaders )
Original file line number Diff line number Diff line change @@ -59,6 +59,7 @@ export function getDefaultIntegrations(options: Options): Integration[] {
5959 linkedErrorsIntegration ( ) ,
6060 winterCGFetchIntegration ( ) ,
6161 consoleIntegration ( ) ,
62+ // TODO(v10): integration can be included - but integration should not add IP address etc
6263 ...( options . sendDefaultPii ? [ requestDataIntegration ( ) ] : [ ] ) ,
6364 ] ;
6465}
You can’t perform that action at this time.
0 commit comments