chore(cli): Stop passing deprecated parameters (#1015)

* chore(cli): Stop passing deprecated parameters

Fixes #1012
Fixes GRADLE-67

* Remove code for backwards-compatibility testing

This test code was added in #576. It ensures that the Gradle plugin gracefully handles the case where we attempt to upload a ProGuard mapping, with release association, to a self-hosted instance which does not yet support ProGuard release association. Since we no longer will support ProGuard release association in the Gradle plugin, this test code has become irrelevant.

Author: szokeasaurusrex

plugin-build/src/main/kotlin/io/sentry/android/gradle/tasks/SentryUploadProguardMappingsTask.kt

@@ -77,17 +77,6 @@ abstract class SentryUploadProguardMappingsTask : SentryCliExecTask() {
     if (!autoUploadProguardMapping.get()) {
       args.add("--no-upload")
     }
-
-    releaseInfo.get().let {
-      it.versionCode?.let { versionCode ->
-        args.add("--version-code")
-        args.add(versionCode.toString())
-      }
-      args.add("--app-id")
-      args.add(it.applicationId)
-      args.add("--version")
-      args.add(it.versionName)
-    }
   }
 
   companion object {

plugin-build/src/test/kotlin/io/sentry/android/gradle/integration/SentryPluginIntegrationTest.kt

@@ -46,10 +46,6 @@ class SentryPluginIntegrationTest :
       build.task(":app:uploadSentryProguardMappingsRelease")?.outcome,
       TaskOutcome.SUCCESS,
     )
-    assertTrue(build.output) {
-      "Most likely you have to update your self-hosted Sentry version " +
-        "to get all of the latest features." in build.output
-    }
   }
 
   @Test

plugin-build/src/test/kotlin/io/sentry/android/gradle/tasks/SentryUploadProguardMappingTaskTest.kt

@@ -49,12 +49,6 @@ class SentryUploadProguardMappingTaskTest {
     assertTrue("--uuid" in args)
     assertTrue(randomUuid.toString() in args)
     assertTrue(mappingFile.get().first().toString() in args)
-    assertTrue("--app-id" in args)
-    assertTrue(releaseInfo.applicationId in args)
-    assertTrue("--version" in args)
-    assertTrue(releaseInfo.versionName in args)
-    assertTrue("--version-code" in args)
-    assertTrue(releaseInfo.versionCode.toString() in args)
     assertFalse("--no-upload" in args)
   }
 
@@ -85,11 +79,6 @@ class SentryUploadProguardMappingTaskTest {
     assertTrue("--uuid" in args)
     assertTrue(randomUuid.toString() in args)
     assertTrue(mappingFile.get().first().toString() in args)
-    assertTrue("--app-id" in args)
-    assertTrue(releaseInfo.applicationId in args)
-    assertTrue("--version" in args)
-    assertTrue(releaseInfo.versionName in args)
-    assertFalse("--version-code" in args)
     assertFalse("--no-upload" in args)
     assertFalse("--log-level=debug" in args)
   }

test/integration-test-server.py

@@ -42,10 +42,7 @@ def do_GET(self):
         self.flushLogs()
 
     def do_POST(self):
-        if self.isApi('/api/0/projects/{}/{}/files/proguard-artifact-releases/'.format(apiOrg, apiProject)):
-            self.start_response(HTTPStatus.NOT_FOUND)
-        else:
-            self.start_response(HTTPStatus.OK)
+        self.start_response(HTTPStatus.OK)
 
         if self.isApi('api/0/projects/{}/{}/files/difs/assemble/'.format(apiOrg, apiProject)):
             # Request body example: