drop skip object arg

Author: ianmacartney

npm-packages/convex/src/react/client.ts

@@ -665,12 +665,6 @@ export type UseQueryOptions<Query extends FunctionReference<"query">> = {
    * @defaultValue undefined
    */
   initialValue?: Query["_returnType"];
-  /**
-   * When true, the query will not be subscribed and it will behave the same as
-   * if it was loading.
-   * @defaultValue false
-   */
-  skip?: boolean;
 } & (FunctionArgs<Query> extends EmptyObject
   ? {
       /**
@@ -703,12 +697,6 @@ export type UseQueryPreloadedOptions<Query extends FunctionReference<"query">> =
      * @defaultValue false
      */
     throwOnError?: boolean;
-    /**
-     * When true, the query will not be subscribed and it will behave the same as
-     * if it was loading.
-     * @defaultValue false
-     */
-    skip?: boolean;
   };
 
 /**
@@ -786,8 +774,7 @@ export function useQuery<Query extends FunctionReference<"query">>(
     typeof queryOrOptions === "object" &&
     queryOrOptions !== null &&
     ("query" in queryOrOptions || "preloaded" in queryOrOptions);
-  const isObjectSkip =
-    queryOrOptions === "skip" || (isObjectOptions && !!queryOrOptions.skip);
+  const isObjectSkip = queryOrOptions === "skip";
   const isLegacy = !isObjectOptions && !isObjectSkip;
   const legacySkip = isLegacy && args[0] === "skip";
   const isObjectReturn = isObjectOptions || isObjectSkip;

npm-packages/convex/src/react/use_query.test.ts

@@ -97,11 +97,16 @@ describe("useQuery types", () => {
       throwOnError: true,
     });
 
-    useQuery({
-      query: api.module.args,
-      args: { _arg: "asdf" },
-      skip: true,
-    });
+    const _arg: string | undefined = undefined;
+
+    useQuery(
+      !_arg
+        ? "skip"
+        : {
+            query: api.module.args,
+            args: { _arg },
+          },
+    );
 
     const {
       status: _status,