Fix off-by-one in go_delete_documents (#43367)

goffrie · Convex, Inc. · commit 1692dd20b6f6 · 2025-11-20T19:23:10.000Z
GitOrigin-RevId: 9a059e5ab4186fb3024814a8a2f757707057b302
diff --git a/crates/database/src/retention.rs b/crates/database/src/retention.rs
@@ -1287,7 +1287,7 @@ impl<RT: Runtime> LeaderRetentionManager<RT> {
                     },
                 }
 
-                is_working = new_cursor < min_document_snapshot_ts;
+                is_working = new_cursor.succ()? < *min_document_snapshot_ts;
                 if is_working {
                     tracing::trace!(
                         "go_delete_documents: processed {scanned_documents:?} rows, more to go"

Original file line number	Diff line number	Diff line change
`@@ -1287,7 +1287,7 @@ impl<RT: Runtime> LeaderRetentionManager<RT> {`
`1287`	`1287`	`},`
`1288`	`1288`	`}`
`1289`	`1289`
`1290`		`- is_working = new_cursor < min_document_snapshot_ts;`
	`1290`	`+ is_working = new_cursor.succ()? < *min_document_snapshot_ts;`
`1291`	`1291`	`if is_working {`
`1292`	`1292`	`tracing::trace!(`
`1293`	`1293`	`"go_delete_documents: processed {scanned_documents:?} rows, more to go"`