Merge PR #689 from Mersho/FavourStaticEmptyFieldsFalseNegative

Fix FavourStaticEmptyFields false negatives.

Author: knocte

src/FSharpLint.Core/Rules/Conventions/FavourStaticEmptyFields.fs

@@ -39,6 +39,19 @@ let private runner (args: AstNodeRuleParams) =
         let emptyLiteralType =
             if isArray then EmptyArrayLiteral else EmptyListLiteral
         generateError range emptyLiteralType
+    | AstNode.Expression(SynExpr.Record(_, _, synExprRecordField, _)) ->
+        synExprRecordField
+        |> List.map (fun field ->
+            match field with
+            | SynExprRecordField(_, _, expr, _) ->
+                match expr with
+                | Some(SynExpr.ArrayOrList(isArray, [], range)) ->
+                    let emptyLiteralType = if isArray then EmptyArrayLiteral else EmptyListLiteral
+                    generateError range emptyLiteralType
+                | Some(SynExpr.Const (SynConst.String ("", _, range), _)) ->
+                    generateError range EmptyStringLiteral
+                | _ -> Array.empty)
+        |> Array.concat
     | _ -> Array.empty
 
 

tests/FSharpLint.Core.Tests/Rules/Conventions/FavourStaticEmptyFields.fs

@@ -77,6 +77,33 @@ let foo a =
         Assert.IsTrue this.ErrorsExist
         Assert.IsTrue (this.ErrorMsg.Contains "Array.empty")
 
+    [<Test>]
+    member this.FavourStaticEmptyFieldsShouldProduceError10() =
+        this.Parse """
+type Person =
+    {
+        FirstName: string
+        Nicknames: List<string>
+    }
+
+{ FirstName = "Foo"; Nicknames = [] } |> ignore"""
+
+        Assert.IsTrue this.ErrorsExist
+        Assert.IsTrue (this.ErrorMsg.Contains "List.Empty")
+
+    [<Test>]
+    member this.FavourStaticEmptyFieldsShouldProduceError11() =
+        this.Parse """
+type Person =
+    {
+        FirstName: string
+    }
+
+{ FirstName = "" } |> ignore"""
+
+        Assert.IsTrue this.ErrorsExist
+        Assert.IsTrue (this.ErrorMsg.Contains "String.Empty")
+
     [<Test>]
     member this.FavourStaticEmptyFieldsShouldNotProduceError1() =
         this.Parse "let bar = String.Empty"