Implemented TimeOnly GraphQL type (#546)

Author: xperiandri

RELEASE_NOTES.md

@@ -230,4 +230,8 @@
 * Fixed ability to override `GraphQLRequestHandler<'Root>`
 * Fixed input object CLR property type validation against GraphQL scalar definitions
 * Migrated all solutions to SLNX format
-* Various performance optimizations and bug fixes
+* Various performance optimizations and bug fixes
+
+### Unreleased
+
+* Added `TimeOnly` GraphQL type

src/FSharp.Data.GraphQL.Server/Schema.fs

@@ -186,6 +186,7 @@ type Schema<'Root> (query: ObjectDef<'Root>, ?mutation: ObjectDef<'Root>, ?subsc
               IDType
               DateTimeOffsetType
               DateOnlyType
+              TimeOnlyType
               UriType
               __Schema
               query ]

src/FSharp.Data.GraphQL.Shared/SchemaDefinitions.fs

@@ -159,6 +159,18 @@ module SchemaDefinitions =
             | false, _ -> None
         | other -> None
 
+    /// Tries to convert any value to TimeOnly.
+    let coerceTimeOnlyValue (x : obj) : TimeOnly option =
+        match x with
+        | null -> None
+        | :? TimeOnly as d -> Some d
+        | :? DateTime as d -> Some (TimeOnly.FromDateTime d)
+        | :? string as s ->
+            match TimeOnly.TryParse(s) with
+            | true, time -> Some time
+            | false, _ -> None
+        | other -> None
+
     /// Tries to convert any value to Guid.
     let coerceGuidValue (x : obj) : Guid option =
         match x with
@@ -348,6 +360,22 @@ module SchemaDefinitions =
             | false, _ -> getParseRangeError(destinationType, DateOnly.MinValue, DateOnly.MaxValue) s
         | InlineConstant value -> value.GetCoerceRangeError(destinationType, DateOnly.MinValue, DateOnly.MaxValue)
 
+    /// Tries to resolve AST query input to TimeOnly.
+    let coerceTimeOnlyInput =
+        let destinationType = "time"
+        function
+        | Variable e when e.ValueKind = JsonValueKind.String ->
+            let s = e.GetString()
+            match TimeOnly.TryParse(s) with
+            | true, time -> Ok time
+            | false, _ -> e.GetDeserializeError destinationType
+        | Variable e -> e.GetDeserializeError destinationType
+        | InlineConstant (StringValue s) ->
+            match TimeOnly.TryParse(s) with
+            | true, time -> Ok time
+            | false, _ -> getParseRangeError(destinationType, TimeOnly.MinValue, TimeOnly.MaxValue) s
+        | InlineConstant value -> value.GetCoerceRangeError(destinationType, TimeOnly.MinValue, TimeOnly.MaxValue)
+
     /// Tries to resolve AST query input to Guid.
     let coerceGuidInput =
         let destinationType = "GUID"
@@ -473,6 +501,15 @@ module SchemaDefinitions =
           CoerceInput = coerceDateOnlyInput
           CoerceOutput = coerceDateOnlyValue }
 
+    /// GraphQL type for System.TimeOnly
+    let TimeOnlyType : ScalarDefinition<TimeOnly> =
+        { Name = "TimeOnly"
+          Description =
+              Some
+                  "The `TimeOnly` scalar type represents a Time value without Date component. The `TimeOnly` type appears in a JSON response as a `String` representation of full-time value as specified by [IETF 3339](https://www.ietf.org/rfc/rfc3339.txt)."
+          CoerceInput = coerceTimeOnlyInput
+          CoerceOutput = coerceTimeOnlyValue }
+
     /// GraphQL type for System.Guid
     let GuidType : ScalarDefinition<Guid> =
         { Name = "Guid"
@@ -759,6 +796,7 @@ module SchemaDefinitions =
         /// </summary>
         /// <param name="name">Type name. Must be unique in scope of the current schema.</param>
         /// <param name="fields">List of input fields defined by the current input object. </param>
+        /// <param name="validator">Object validator.</param>
         /// <param name="description">Optional input object description. Useful for generating documentation.</param>
         static member InputObject(name : string, fields : InputFieldDef list, validator: GQLValidator<'Out>, ?description : string) : InputObjectDefinition<'Out> =
             { Name = name

tests/FSharp.Data.GraphQL.IntegrationTests/introspection.json

@@ -1,5 +1,5 @@
 {
-  "documentId": 1481480240,
+  "documentId": -128167532,
   "data": {
     "__schema": {
       "queryType": {
@@ -82,6 +82,16 @@
           "enumValues": null,
           "possibleTypes": null
         },
+        {
+          "kind": "SCALAR",
+          "name": "TimeOnly",
+          "description": "The `TimeOnly` scalar type represents a Time value without Date component. The `TimeOnly` type appears in a JSON response as a `String` representation of full-time value as specified by [IETF 3339](https://www.ietf.org/rfc/rfc3339.txt).",
+          "fields": null,
+          "inputFields": null,
+          "interfaces": null,
+          "enumValues": null,
+          "possibleTypes": null
+        },
         {
           "kind": "SCALAR",
           "name": "URI",

tests/FSharp.Data.GraphQL.Tests/IntrospectionTests.fs

@@ -691,6 +691,16 @@ let ``Introspection executes an introspection query`` () =
                             "enumValues", null
                             "possibleTypes", null
                     ]
+                    box <| NameValueLookup.ofList [
+                            "kind", upcast "SCALAR"
+                            "name", upcast "TimeOnly"
+                            "description", upcast "The `TimeOnly` scalar type represents a Time value without Date component. The `TimeOnly` type appears in a JSON response as a `String` representation of full-time value as specified by [IETF 3339](https://www.ietf.org/rfc/rfc3339.txt)."
+                            "fields", null
+                            "inputFields", null
+                            "interfaces", null
+                            "enumValues", null
+                            "possibleTypes", null
+                    ]
                     box <| NameValueLookup.ofList [
                             "kind", upcast "SCALAR"
                             "name", upcast "URI"