Fix by using shell cmd, instead of default pwsh, which swallows %errorlevel%

Author: abelbraaksma

.github/workflows/build.yaml

@@ -17,4 +17,7 @@ jobs:
         uses: actions/setup-dotnet@v3
       # build it, test it, pack it
       - name: Run dotnet build (release)
+        # see issue #105
+        # very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
+        shell: cmd
         run: ./build.cmd

.github/workflows/main.yaml

@@ -20,6 +20,9 @@ jobs:
         uses: actions/setup-dotnet@v3
       # build it, test it, pack it
       - name: Run dotnet build (release)
+        # see issue #105
+        # very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
+        shell: cmd
         run: ./build.cmd
 
   test-release:
@@ -36,6 +39,9 @@ jobs:
         uses: actions/setup-dotnet@v3
       # build it, test it, pack it
       - name: Run dotnet test - release
+        # see issue #105
+        # very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
+        shell: cmd
         run: ./build.cmd ci -release
       - name: Publish test results - release
         uses: dorny/test-reporter@v1

.github/workflows/publish.yaml

@@ -20,6 +20,8 @@ jobs:
         uses: actions/setup-dotnet@v3
       # build it, test it, pack it, publish it
       - name: Run dotnet build (release, for nuget)
+        # see issue #105
+        # very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
         run: ./build.cmd
       - name: Nuget publish
         # skip-duplicate ensures that the 409 error received when the package was already published,

.github/workflows/test-report.yaml

@@ -16,7 +16,7 @@ jobs:
     - uses: dorny/test-reporter@v1
       with:
         artifact: test-results-release    # artifact name
-        name: Report release tests         # Name of the check run which will be created
+        name: Report release tests        # Name of the check run which will be created
         path: '*.trx'                     # Path to test results (inside artifact .zip)
         reporter: dotnet-trx              # Format of test results
 
@@ -26,6 +26,6 @@ jobs:
     - uses: dorny/test-reporter@v1
       with:
         artifact: test-results-debug      # artifact name
-        name: Report debug tests           # Name of the check run which will be created
+        name: Report debug tests          # Name of the check run which will be created
         path: '*.trx'                     # Path to test results (inside artifact .zip)
         reporter: dotnet-trx              # Format of test results

.github/workflows/test.yaml

@@ -19,6 +19,9 @@ jobs:
 
       # build it, test it
       - name: Run dotnet test - release
+        # see issue #105
+        # very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
+        shell: cmd 
         run: ./build.cmd ci -release
 
       # upload test results
@@ -46,6 +49,9 @@ jobs:
 
       # build it, test it
       - name: Run dotnet test - debug
+        # see issue #105
+        # very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
+        shell: cmd
         run: ./build.cmd ci -debug
 
       # upload test results

src/FSharp.Control.TaskSeq/Utils.fs

@@ -12,7 +12,7 @@ module ValueTaskExtensions =
         static member inline CompletedTask = Unchecked.defaultof<ValueTask>
 
 
-module ValueTask =
+module ValueTask 
     /// A successfully completed ValueTask of boolean that has the value false.
     let False = ValueTask<bool>()