Skip to content

Commit 8305614

Browse files
committed
Fix by using shell cmd, instead of default pwsh, which swallows %errorlevel%
1 parent e521694 commit 8305614

File tree

4 files changed

+16
-0
lines changed

4 files changed

+16
-0
lines changed

.github/workflows/build.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@ jobs:
1717
uses: actions/setup-dotnet@v3
1818
# build it, test it, pack it
1919
- name: Run dotnet build (release)
20+
# see issue #105
21+
# very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
2022
shell: cmd
2123
run: ./build.cmd

.github/workflows/main.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ jobs:
2020
uses: actions/setup-dotnet@v3
2121
# build it, test it, pack it
2222
- name: Run dotnet build (release)
23+
# see issue #105
24+
# very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
25+
shell: cmd
2326
run: ./build.cmd
2427

2528
test-release:
@@ -36,6 +39,9 @@ jobs:
3639
uses: actions/setup-dotnet@v3
3740
# build it, test it, pack it
3841
- name: Run dotnet test - release
42+
# see issue #105
43+
# very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
44+
shell: cmd
3945
run: ./build.cmd ci -release
4046
- name: Publish test results - release
4147
uses: dorny/test-reporter@v1

.github/workflows/publish.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ jobs:
2020
uses: actions/setup-dotnet@v3
2121
# build it, test it, pack it, publish it
2222
- name: Run dotnet build (release, for nuget)
23+
# see issue #105
24+
# very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
2325
run: ./build.cmd
2426
- name: Nuget publish
2527
# skip-duplicate ensures that the 409 error received when the package was already published,

.github/workflows/test.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ jobs:
1919

2020
# build it, test it
2121
- name: Run dotnet test - release
22+
# see issue #105
23+
# very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
24+
shell: cmd
2225
run: ./build.cmd ci -release
2326

2427
# upload test results
@@ -46,6 +49,9 @@ jobs:
4649

4750
# build it, test it
4851
- name: Run dotnet test - debug
52+
# see issue #105
53+
# very important, since we use cmd scripts, the default is psh, and a bug prevents errorlevel to bubble
54+
shell: cmd
4955
run: ./build.cmd ci -debug
5056

5157
# upload test results

0 commit comments

Comments
 (0)