Renames, cleanup and overall fixup of task-for and async-for CE code

Author: abelbraaksma

src/FSharp.Control.TaskSeq/AsyncExtensions.fs

@@ -1,36 +1,14 @@
 namespace FSharp.Control
 
-open System.Collections.Generic
-open System.Threading
-open System.Threading.Tasks
-
-#nowarn "57"
-#nowarn "1204"
-#nowarn "3513"
-
+open FSharp.Control.TaskSeqBuilders
 
 [<AutoOpen>]
 module AsyncExtensions =
 
     // Add asynchronous for loop to the 'async' computation builder
     type Microsoft.FSharp.Control.AsyncBuilder with
 
-        member x.For(tasksq: IAsyncEnumerable<'T>, action: 'T -> Async<unit>) =
-            tasksq
+        member _.For(source: taskSeq<'T>, action: 'T -> Async<unit>) =
+            source
             |> TaskSeq.iterAsync (action >> Async.StartAsTask)
             |> Async.AwaitTask
-
-
-    // temp example
-    let foo () = async {
-        let mutable sum = 0
-
-        let xs = taskSeq {
-            1
-            2
-            3
-        }
-
-        for x in xs do
-            sum <- sum + x
-    }

src/FSharp.Control.TaskSeq/AsyncExtensions.fsi

@@ -1,10 +1,10 @@
 namespace FSharp.Control
 
-#nowarn "1204"
-
 [<AutoOpen>]
 module AsyncExtensions =
+    open FSharp.Control.TaskSeqBuilders
 
     type AsyncBuilder with
 
-        member For: tasksq: System.Collections.Generic.IAsyncEnumerable<'T> * action: ('T -> Async<unit>) -> Async<unit>
+        /// Iterate over all values of a taskSeq.
+        member For: source: taskSeq<'T> * action: ('T -> Async<unit>) -> Async<unit>

src/FSharp.Control.TaskSeq/TaskExtensions.fs

@@ -4,16 +4,17 @@ open System.Collections.Generic
 open System.Threading
 open System.Threading.Tasks
 
+open Microsoft.FSharp.Core.CompilerServices
+open Microsoft.FSharp.Core.LanguagePrimitives.IntrinsicOperators
+
+open FSharp.Control.TaskSeqBuilders
+
 #nowarn "57"
 #nowarn "1204"
 #nowarn "3513"
 
-
 [<AutoOpen>]
 module TaskExtensions =
-    open Microsoft.FSharp.Core.CompilerServices
-    open Microsoft.FSharp.Core.CompilerServices.StateMachineHelpers
-    open Microsoft.FSharp.Core.LanguagePrimitives.IntrinsicOperators
 
     let rec WhileDynamic
         (
@@ -104,42 +105,11 @@ module TaskExtensions =
                         false)
             )
 
-        member inline this.For(tasksq: IAsyncEnumerable<'T>, body: 'T -> TaskCode<_, unit>) : TaskCode<_, unit> =
-            // tasksq
-            // |> TaskSeq.iterAsync (body >> task.Run)
-            // |> task.ReturnFrom
-
-            // task.ReturnFrom <|
-            //     task {
-            //         let mutable continueWhile = true
-            //         use e = tasksq.GetAsyncEnumerator()
-            //         while continueWhile do
-            //             let! next = e.MoveNextAsync()
-            //             if next then
-            //                 do! task.Run(body e.Current)
-            //             else
-            //                 continueWhile <- false
-            //     }
-
+        member inline this.For(source: taskSeq<'T>, body: 'T -> TaskCode<_, unit>) : TaskCode<_, unit> =
             TaskCode<'TOverall, unit>(fun sm ->
-
                 this
                     .Using(
-                        tasksq.GetAsyncEnumerator(CancellationToken()),
+                        source.GetAsyncEnumerator(CancellationToken()),
                         (fun e -> this.WhileAsync(e.MoveNextAsync, (fun sm -> (body e.Current).Invoke(&sm))))
                     )
                     .Invoke(&sm))
-
-    // temp example
-    let foo () = task {
-        let mutable sum = 0
-
-        let xs = taskSeq {
-            1
-            2
-            3
-        }
-
-        for x in xs do
-            sum <- sum + x
-    }

src/FSharp.Control.TaskSeq/TaskExtensions.fsi

@@ -4,26 +4,8 @@ namespace FSharp.Control
 
 [<AutoOpen>]
 module TaskExtensions =
-
-    val WhileDynamic:
-        sm: byref<TaskStateMachine<'Data>> *
-        condition: (unit -> System.Threading.Tasks.ValueTask<bool>) *
-        body: TaskCode<'Data, unit> ->
-            bool
-
-    val WhileBodyDynamicAux:
-        sm: byref<TaskStateMachine<'Data>> *
-        condition: (unit -> System.Threading.Tasks.ValueTask<bool>) *
-        body: TaskCode<'Data, unit> *
-        rf: TaskResumptionFunc<'Data> ->
-            bool
+    open FSharp.Control.TaskSeqBuilders
 
     type TaskBuilder with
 
-        member inline WhileAsync:
-            condition: (unit -> System.Threading.Tasks.ValueTask<bool>) * body: TaskCode<'TOverall, unit> ->
-                TaskCode<'TOverall, unit>
-
-        member inline For:
-            tasksq: System.Collections.Generic.IAsyncEnumerable<'T> * body: ('T -> TaskCode<'TOverall, unit>) ->
-                TaskCode<'TOverall, unit>
+        member inline For: source: taskSeq<'T> * body: ('T -> TaskCode<'TOverall, unit>) -> TaskCode<'TOverall, unit>