Addresses review comments

1. Fixes conditional trigger for linting
2. Moves which as a dependency
3. Adds logging output for when parts of the extension are enabled

Author: gnikit

package-lock.json

@@ -250,8 +250,7 @@
     "tslint": "^5.20.1",
     "typescript": "^3.5.1",
     "vscode": "^1.1.37",
-    "vscode-tmgrammar-test": "^0.0.11",
-    "which": "^2.0.2"
+    "vscode-tmgrammar-test": "^0.0.11"
   },
   "husky": {
     "hooks": {
@@ -264,6 +263,7 @@
     ]
   },
   "dependencies": {
-    "vscode-languageclient": "^5.1.0"
+    "vscode-languageclient": "^5.1.0",
+    "which": "^2.0.2"
   }
 }

package.json

@@ -25,6 +25,7 @@ export function activate(context: vscode.ExtensionContext) {
     let linter = new FortranLintingProvider(loggingService)
     linter.activate(context.subscriptions)
     vscode.languages.registerCodeActionsProvider(FORTRAN_DOCUMENT_SELECTOR, linter)
+    loggingService.logInfo('Linter is enabled')
   } else {
     loggingService.logInfo('Linter is not enabled')
   }
@@ -36,6 +37,7 @@ export function activate(context: vscode.ExtensionContext) {
         new FortranFormattingProvider(loggingService)
       );
     context.subscriptions.push(disposable);
+    loggingService.logInfo('Formatting is enabled')
   }
   else {
     loggingService.logInfo('Formatting is disabled')
@@ -54,6 +56,7 @@ export function activate(context: vscode.ExtensionContext) {
   if (extensionConfig.get('provideHover', true)) {
     let hoverProvider = new FortranHoverProvider(loggingService)
     vscode.languages.registerHoverProvider(FORTRAN_DOCUMENT_SELECTOR, hoverProvider)
+    loggingService.logInfo('Hover Provider is enabled')
   } else {
     loggingService.logInfo('Hover Provider is not enabled')
   }
@@ -64,6 +67,7 @@ export function activate(context: vscode.ExtensionContext) {
       FORTRAN_DOCUMENT_SELECTOR,
       symbolProvider
     )
+    loggingService.logInfo('Symbol Provider is enabled')
   } else {
     loggingService.logInfo('Symbol Provider is not enabled')
   }

src/extension.ts

@@ -18,8 +18,8 @@ export default class FortranLintingProvider {
 
     // Only lint Fortran (free, fixed) format files
     if (
-      FORTRAN_DOCUMENT_SELECTOR.some((element) => { element.language !== textDocument.languageId }) ||
-      FORTRAN_DOCUMENT_SELECTOR.some((element) => { element.scheme !== textDocument.uri.scheme })
+      !FORTRAN_DOCUMENT_SELECTOR.some(e => e.scheme === textDocument.uri.scheme) ||
+      !FORTRAN_DOCUMENT_SELECTOR.some(e => e.language === textDocument.languageId)
     ) {
       return
     }
@@ -138,7 +138,7 @@ export default class FortranLintingProvider {
   private command: vscode.Disposable
 
   public activate(subscriptions: vscode.Disposable[]) {
-    this.diagnosticCollection = vscode.languages.createDiagnosticCollection()
+    this.diagnosticCollection = vscode.languages.createDiagnosticCollection('Fortran')
 
     vscode.workspace.onDidOpenTextDocument(
       this.doModernFortranLint,