Fix: fpm stopped running after printing help (#728)

Stop fpm​​ from running after printing help_text.

Author: zoziha

src/fpm.f90

@@ -7,7 +7,7 @@ module fpm
                       fpm_clean_settings
 use fpm_dependency, only : new_dependency_tree
 use fpm_environment, only: get_env
-use fpm_filesystem, only: is_dir, join_path, number_of_rows, list_files, exists, &
+use fpm_filesystem, only: is_dir, join_path, list_files, exists, &
                    basename, filewrite, mkdir, run, os_delete_dir
 use fpm_model, only: fpm_model_t, srcfile_t, show_model, &
                     FPM_SCOPE_UNKNOWN, FPM_SCOPE_LIB, FPM_SCOPE_DEP, &

src/fpm_command_line.f90

@@ -192,9 +192,9 @@ module fpm_command_line
     subroutine get_command_line_settings(cmd_settings)
         class(fpm_cmd_settings), allocatable, intent(out) :: cmd_settings
 
+        integer, parameter            :: widest = 256
         character(len=4096)           :: cmdarg
         integer                       :: i
-        integer                       :: widest
         integer                       :: os
         logical                       :: unix
         type(fpm_install_settings), allocatable :: install_settings
@@ -434,7 +434,6 @@ subroutine get_command_line_settings(cmd_settings)
             elseif(unnamed(2)=='manual')then
                 unnamed=manual
             endif
-            widest=256
             allocate(character(len=widest) :: help_text(0))
             do i=2,size(unnamed)
                 select case(unnamed(i))
@@ -507,10 +506,12 @@ subroutine get_command_line_settings(cmd_settings)
             call set_args(common_args // '&
             & --list F&
             &', help_list, version_text)
-            call printhelp(help_list_nodash)
             if(lget('list'))then
-               call printhelp(help_list_dash)
+                help_text = [character(widest) :: help_list_nodash, help_list_dash]
+            else
+                help_text = help_list_nodash
             endif
+            call printhelp(help_text)
 
         case('test')
             call set_args(common_args // compiler_args // run_args // ' --', &
@@ -592,23 +593,23 @@ subroutine get_command_line_settings(cmd_settings)
 
             if(cmdarg.ne.''.and.which('fpm-'//cmdarg).ne.'')then
                 call run('fpm-'//trim(cmdarg)//' '// get_command_arguments_quoted(),.false.)
+                stop
             else
                 call set_args('&
                 & --list F&
                 &', help_fpm, version_text)
                 ! Note: will not get here if --version or --usage or --help
                 ! is present on commandline
-                help_text=help_usage
                 if(lget('list'))then
-                   help_text=help_list_dash
+                    help_text = help_list_dash
                 elseif(len_trim(cmdarg)==0)then
                     write(stdout,'(*(a))')'Fortran Package Manager:'
                     write(stdout,'(*(a))')' '
-                    call printhelp(help_list_nodash)
+                    help_text = [character(widest) :: help_list_nodash, help_usage]
                 else
                     write(stderr,'(*(a))')'<ERROR> unknown subcommand [', &
                      & trim(cmdarg), ']'
-                    call printhelp(help_list_dash)
+                    help_text = [character(widest) :: help_list_dash, help_usage]
                 endif
                 call printhelp(help_text)
             endif
@@ -638,6 +639,7 @@ subroutine check_build_vals()
 
     end subroutine check_build_vals
 
+    !> Print help text and stop
     subroutine printhelp(lines)
     character(len=:),intent(in),allocatable :: lines(:)
     integer :: iii,ii
@@ -649,6 +651,7 @@ subroutine printhelp(lines)
                write(stdout,'(a)')'<WARNING> *printhelp* output requested is empty'
            endif
         endif
+        stop
     end subroutine printhelp
 
     end subroutine get_command_line_settings