Skip to content

Commit 6a8779c

Browse files
committed
append data prefix, env var gate
1 parent 46c7897 commit 6a8779c

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

genkit-tools/telemetry-server/src/broadcast-manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export class BroadcastManager {
7171
}
7272

7373
const data = JSON.stringify(event);
74-
const messageToSend = `${data}\n\n`;
74+
const messageToSend = `data: ${data}\n\n`;
7575

7676
// Note: response.write() doesn't throw on dead sockets in Express - it
7777
// returns false and the 'close' event handles cleanup. No try/catch needed.

genkit-tools/telemetry-server/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export async function startTelemetryServer(params: {
8181
const currentTrace = await params.traceStore.load(traceId);
8282
if (currentTrace) {
8383
const snapshot = JSON.stringify(currentTrace);
84-
response.write(`${snapshot}\n\n`);
84+
response.write(`data: ${snapshot}\n\n`);
8585
}
8686

8787
// Register this connection for broadcasts

js/core/src/tracing/node-telemetry-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ async function cleanUpTracing(): Promise<void> {
8989
*/
9090
function createTelemetryServerProcessor(): SpanProcessor {
9191
const exporter = new TraceServerExporter();
92-
// Use RealtimeSpanProcessor in dev for real-time span updates
93-
return isDevEnv()
92+
// Use RealtimeSpanProcessor when explicitly enabled via env var (set by CLI)
93+
return isDevEnv() && process.env.GENKIT_ENABLE_REALTIME_TELEMETRY === 'true'
9494
? new RealtimeSpanProcessor(exporter)
9595
: new BatchSpanProcessor(exporter);
9696
}

0 commit comments

Comments
 (0)