Moved template retrieval in-line (#1077)

Author: kevinthecheung

2nd-gen/remote-config-diff/functions/index.js

@@ -22,62 +22,54 @@ const {onConfigUpdated} = require("firebase-functions/v2/remoteConfig");
 const logger = require("firebase-functions/logger");
 // The Firebase Admin SDK to obtain access tokens.
 const admin = require("firebase-admin");
-admin.initializeApp();
+const app = admin.initializeApp();
 const fetch = require("node-fetch");
 const jsonDiff = require("json-diff");
 // [END import]
 
 // [START showconfigdiff]
-exports.showconfigdiff = onConfigUpdated((event) => {
-  // Obtain the access token from the admin SDK
-  return admin.credential.applicationDefault().getAccessToken()
-      .then((accessTokenObj) => {
-        return accessTokenObj.access_token;
-      })
-      .then((accessToken) => {
-      // Get the version number from the event object
-        const currentVersion = event.data.versionNumber;
-        const templatePromises = [];
-        templatePromises.push(getTemplate(currentVersion, accessToken));
-        templatePromises.push(getTemplate(currentVersion - 1, accessToken));
-        // Get the templates
-        return Promise.all(templatePromises);
-      })
-      .then((results) => {
-        const currentTemplate = results[0];
-        const previousTemplate = results[1];
-        // Figure out the differences of the templates
-        const diff = jsonDiff.diffString(previousTemplate, currentTemplate);
-        // Log the difference
-        logger.log(diff);
+exports.showconfigdiff = onConfigUpdated(async (event) => {
+  try {
+    // Obtain the access token from the Admin SDK
+    const accessTokenObj = await admin.credential.applicationDefault()
+        .getAccessToken();
+    const accessToken = accessTokenObj.access_token;
 
-        return null;
-      }).catch((error) => {
-        logger.error(error);
-        return null;
-      });
+    // Get the version number from the event object
+    const remoteConfigApi = "https://firebaseremoteconfig.googleapis.com/v1/" +
+        `projects/${app.options.projectId}/remoteConfig`;
+    const currentVersion = event.data.versionNumber;
+    const prevVersion = currentVersion - 1;
+    const templatePromises = [];
+    templatePromises.push(fetch(
+        remoteConfigApi,
+        {
+          method: "POST",
+          body: new URLSearchParams([["versionNumber", currentVersion + ""]]),
+          headers: {Authorization: "Bearer " + accessToken},
+        },
+    ));
+    templatePromises.push(fetch(
+        remoteConfigApi,
+        {
+          method: "POST",
+          body: new URLSearchParams([["versionNumber", prevVersion + ""]]),
+          headers: {Authorization: "Bearer " + accessToken},
+        },
+    ));
+
+    // Get the templates
+    const responses = await Promise.all(templatePromises);
+    const results = responses.map((r) => r.json());
+    const currentTemplate = results[0];
+    const previousTemplate = results[1];
+    // Figure out the differences of the templates
+    const diff = jsonDiff.diffString(previousTemplate, currentTemplate);
+    // Log the difference
+    logger.log(diff);
+  } catch (error) {
+    logger.error(error);
+  }
 });
 // [END showconfigdiff]
-
-// [START getTemplate]
-/**
- * Get a specific version of a Remote Config template
- * @param {number} version
- * @param {string} accessToken
- * @return {Promise<string>} the template as JSON
- */
-async function getTemplate(version, accessToken) {
-  const params = new URLSearchParams();
-  params.append("versionNumber", version + "");
-  const response = await fetch(
-      "https://firebaseremoteconfig.googleapis.com/v1/projects/remote-config-function/remoteConfig",
-      {
-        method: "POST",
-        body: params,
-        headers: {Authorization: "Bearer " + accessToken},
-      },
-  );
-  return response.json();
-}
-// [END getTemplate]
 // [END all]