noop: Refactor FirebaseSessions.LocalOverrideSettings code (#15523)

Author: ncooke3

FirebaseSessions/Sources/SessionInitiator.swift

@@ -112,7 +112,8 @@ class SessionInitiator {
   @objc private func appForegrounded() {
     let interval = currentTime().timeIntervalSince(backgroundTime)
 
-    // If the interval is greater the the session timeout duration, generate a new session.
+    // If the interval is greater than the session timeout duration, generate
+    // a new session.
     if interval > settings.sessionTimeout {
       initiateSessionStart()
     }

FirebaseSessions/Sources/Settings/LocalOverrideSettings.swift

@@ -17,51 +17,38 @@ import Foundation
 
 /// Class that manages the local overrides configs related to the library.
 class LocalOverrideSettings: SettingsProvider {
-  // This will disable Sessions SDK Events, but not Settings requests.
-  // If any apps use this flag to disable the Firebase Sessions SDK,
-  // keep in mind this may break metrics future features with products like
-  // FirePerf and Crashlytics. As a result, we would recommend apps
-  // use another way to disable data collection (like disabling it via
-  // the product public data collection APIs themselves).
-  // This flag is internal and may break in the future.
-  static let PlistKey_sessions_enabled = "FirebaseSessionsEnabled"
-  static let PlistKey_sessions_timeout = "FirebaseSessionsTimeout"
-  static let PlistKey_sessions_samplingRate = "FirebaseSessionsSampingRate"
+  private enum PlistKey: String {
+    /// This will disable Sessions SDK Events, but not Settings requests.
+    /// If any apps use this flag to disable the Firebase Sessions SDK,
+    /// keep in mind this may break metrics future features with products like
+    /// FirePerf and Crashlytics. As a result, we would recommend apps
+    /// use another way to disable data collection (like disabling it via
+    /// the product public data collection APIs themselves).
+    /// This flag is internal and may break in the future.
+    case sessionsEnabled = "FirebaseSessionsEnabled"
+    case sessionsTimeout = "FirebaseSessionsTimeout"
+    case sessionsSamplingRate = "FirebaseSessionsSampingRate"
+  }
 
   var sessionsEnabled: Bool? {
-    let session_enabled = plistValueForConfig(configName: LocalOverrideSettings
-      .PlistKey_sessions_enabled) as? Bool
-    if session_enabled != nil {
-      return Bool(session_enabled!)
-    }
-    return nil
+    let isEnabled = plistValue(for: .sessionsEnabled)
+    return isEnabled as? Bool
   }
 
   var sessionTimeout: TimeInterval? {
-    let timeout = plistValueForConfig(configName: LocalOverrideSettings
-      .PlistKey_sessions_timeout) as? Double
-    if timeout != nil {
-      return Double(timeout!)
-    }
-    return nil
+    let timeout = plistValue(for: .sessionsTimeout)
+    return timeout as? Double
   }
 
   var samplingRate: Double? {
-    let rate = plistValueForConfig(configName: LocalOverrideSettings
-      .PlistKey_sessions_samplingRate) as? Double
-    if rate != nil {
-      return Double(rate!)
-    }
-    return nil
+    let rate = plistValue(for: .sessionsSamplingRate)
+    return rate as? Double
   }
 
-  private func plistValueForConfig(configName: String) -> Any? {
-    return Bundle.main.infoDictionary?[configName]
+  private func plistValue(for key: PlistKey) -> Any? {
+    return Bundle.main.infoDictionary?[key.rawValue]
   }
-}
 
-typealias LocalOverrideSettingsProvider = LocalOverrideSettings
-extension LocalOverrideSettingsProvider {
   func updateSettings() {
     // Nothing to be done since there is nothing to be updated.
   }

FirebaseSessions/Sources/Settings/RemoteSettings.swift

@@ -76,10 +76,7 @@ final class RemoteSettings: SettingsProvider, Sendable {
       }
     }
   }
-}
 
-typealias RemoteSettingsConfigurations = RemoteSettings
-extension RemoteSettingsConfigurations {
   var sessionsEnabled: Bool? {
     return sessionsCache[RemoteSettings.flagSessionsEnabled] as? Bool
   }
@@ -91,10 +88,7 @@ extension RemoteSettingsConfigurations {
   var sessionTimeout: TimeInterval? {
     return sessionsCache[RemoteSettings.flagSessionTimeout] as? Double
   }
-}
 
-typealias RemoteSettingsProvider = RemoteSettings
-extension RemoteSettingsConfigurations {
   func updateSettings(currentTime: Date) {
     fetchAndCacheSettings(currentTime: currentTime)
   }