Forward C++ API-wide log verbosity to platform specific SDK logger.

In addition, the logger now logs to the MSVC debug window.

PiperOrigin-RevId: 252896509

Author: smiles

app/src/log.cc

@@ -150,6 +150,7 @@ static void LogMessageWithCallbackV(LogLevel log_level, const char* format,
 
 void SetLogLevel(LogLevel level) {
   g_log_level = level;
+  LogSetPlatformLevel(level);
 }
 
 LogLevel GetLogLevel() { return g_log_level; }

app/src/log.h

@@ -38,6 +38,9 @@ LogLevel GetLogLevel();
 FIREBASE_DEPRECATED void LogSetLevel(LogLevel level);
 // Use firebase::GetLogLevel() instead.
 FIREBASE_DEPRECATED LogLevel LogGetLevel();
+// Set the platform specific SDK log level.
+// This is called internally by LogSetLevel().
+void LogSetPlatformLevel(LogLevel level);
 // Log a debug message to the system log.
 void LogDebug(const char* format, ...);
 // Log an info message to the system log.

app/src/log_android.cc

@@ -45,6 +45,15 @@ void AndroidLogMessageV(int priority, const char* tag, const char* format,
   __android_log_vprint(priority, tag, format, args);
 }
 
+// Set the platform specific SDK log level.
+void LogSetPlatformLevel(LogLevel level) {
+  // This isn't available on Android, instead logs go through the framework's
+  // android.util.Log.  Some modules, like Analytics and Realtime Database,
+  // have their own custom logging which are enabled via system configuration
+  // variables or module-specific API calls.
+  (void)level;
+}
+
 // Log a firebase message.
 void LogMessageV(LogLevel log_level, const char* format, va_list args) {
   switch (log_level) {

app/src/log_ios.mm

@@ -18,13 +18,28 @@
 
 #import <Foundation/Foundation.h>
 
+#import "FIRLoggerLevel.h"
+
 #include <stdarg.h>
 
+// Private API to set the logger level in Firebase/Core/Private/FIRLogger.h.
+extern "C" void FIRSetLoggerLevel(FIRLoggerLevel loggerLevel);
+
 namespace firebase {
 
 // Key used in Info.plist to configure the log level before a load of code is executed.
 static NSString* kLogLevelInfoPlistKey = @"FIRCPPLogLevel";
 
+// Maps C++ to iOS SDK log levels.
+static const FIRLoggerLevel kCppToIOSLogLevel[] = {
+  FIRLoggerLevelDebug, // kLogLevelVerbose = 0,
+  FIRLoggerLevelDebug, // kLogLevelDebug,
+  FIRLoggerLevelInfo,  // kLogLevelInfo,
+  FIRLoggerLevelWarning, // kLogLevelWarning,
+  FIRLoggerLevelError, // kLogLevelError,
+  FIRLoggerLevelError, // kLogLevelAssert,
+};
+
 // Initialize the logging system.
 void LogInitialize() {
   static bool read_log_level_from_plist = false;
@@ -38,6 +53,14 @@ void LogInitialize() {
       LogSetLevel(static_cast<LogLevel>(log_level_value));
     }
   }
+  // Synchronize the platform logger with the C++ log level.
+  LogSetPlatformLevel(LogGetLevel());
+}
+
+// Set the platform specific SDK log level.
+void LogSetPlatformLevel(LogLevel level) {
+  assert(level < sizeof(kCppToIOSLogLevel) / sizeof(kCppToIOSLogLevel[0]));
+  FIRSetLoggerLevel(kCppToIOSLogLevel[level]);
 }
 
 // Log a firebase message.
@@ -64,5 +87,4 @@ void LogMessageV(LogLevel log_level, const char* format, va_list args) {
   }
 }
 
-
 }  // namespace firebase

app/src/log_stdio.cc

@@ -16,41 +16,65 @@
 
 #include "app/src/log.h"
 
+#include <assert.h>
 #include <stdarg.h>
 #include <stdio.h>
+#include <string.h>
+
+#ifdef _WIN32
+#include <Windows.h>
+#endif  // _WIN32
+
+#include "app/src/mutex.h"
+#include "app/src/include/firebase/internal/platform.h"
 
 #if !defined(FIREBASE_NAMESPACE)
 #define FIREBASE_NAMESPACE firebase
 #endif
 
 namespace FIREBASE_NAMESPACE {
 
+// Prefix for log messages at each level.
+static const char* kLogLevelPrefix[] = {
+  "VERBOSE: ",  // kLogLevelVerbose = 0,
+  "DEBUG: ",  // kLogLevelDebug,
+  "INFO: ",   // kLogLevelInfo,
+  "WARNING: ",  // kLogLevelWarning,
+  "ERROR: ",  // kLogLevelError,
+  "ASSERT: ",  // kLogLevelAssert,
+};
+
+#ifdef _WIN32
+// Guards the log buffer on Windows.
+static Mutex g_log_mutex;  // NOLINT
+#endif  // _WIN32
+
 // Initializes the logging module.
 void LogInitialize() {}
 
+// Set the platform specific SDK log level.
+void LogSetPlatformLevel(LogLevel level) {}
+
 // Log a firebase message.
 void LogMessageV(LogLevel log_level, const char* format, va_list args) {
-  switch (log_level) {
-    case kLogLevelVerbose:
-      printf("VERBOSE: ");
-      break;
-    case kLogLevelDebug:
-      printf("DEBUG: ");
-      break;
-    case kLogLevelInfo:
-      break;
-    case kLogLevelWarning:
-      printf("WARNING: ");
-      break;
-    case kLogLevelError:
-      printf("ERROR: ");
-      break;
-    case kLogLevelAssert:
-      printf("ASSERT: ");
-      break;
-  }
+  assert(log_level < (sizeof(kLogLevelPrefix) / sizeof(kLogLevelPrefix[0])));
+  const char* prefix = kLogLevelPrefix[log_level];
+  printf("%s", prefix);
   vprintf(format, args);
   printf("\n");
+  // Platform specific logging.
+#if FIREBASE_PLATFORM_WINDOWS
+  {
+    MutexLock lock(g_log_mutex);
+    static char log_buffer[1024];
+    size_t prefix_length = strlen(prefix);
+    strcpy(log_buffer, prefix);  // // NOLINT
+    vsnprintf(log_buffer + prefix_length,
+              sizeof(log_buffer) - 1 - prefix_length, format, args);  // NOLINT
+    log_buffer[sizeof(log_buffer) - 1] = '\0';
+    OutputDebugString(log_buffer);
+  }
+#endif  // FIREBASE_PLATFORM_WINDOWS
 }
 
 // NOLINTNEXTLINE - allow namespace overridden