Avoid empty statement warnings in Firebase assertions

Wrapping macro bodies in do { } while(false) makes them into a statement that
legitimately should be followed by a semicolon.

PiperOrigin-RevId: 320272779

Author: wilhuff

app/src/assert.h

@@ -45,13 +45,13 @@
 // Assert condition is true, if it's false log an assert with the specified
 // expression as a string.
 #define FIREBASE_ASSERT_WITH_EXPRESSION(condition, expression)      \
-  {                                                                 \
+  do {                                                              \
     if (!(condition)) {                                             \
-      FIREBASE_NAMESPACE::LogAssert(                                  \
+      FIREBASE_NAMESPACE::LogAssert(                                \
           FIREBASE_ASSERT_MESSAGE_PREFIX FIREBASE_EXPAND_STRINGIFY( \
               expression));                                         \
     }                                                               \
-  }
+  } while (false)
 
 // Assert condition is true, if it's false log an assert with the specified
 // expression as a string. Compiled out of release builds.
@@ -60,7 +60,7 @@
   FIREBASE_ASSERT_WITH_EXPRESSION(condition, expression)
 #else
 #define FIREBASE_DEV_ASSERT_WITH_EXPRESSION(condition, expression) \
-  { (void)(condition); }
+  (void)(condition)
 #endif  // !defined(NDEBUG)
 
 // Custom assert() implementation that is not compiled out in release builds.
@@ -111,14 +111,14 @@
 // Assert condition is true otherwise display the specified expression,
 // message and abort.
 #define FIREBASE_ASSERT_MESSAGE_WITH_EXPRESSION(condition, expression, ...) \
-  {                                                                         \
+  do {                                                                      \
     if (!(condition)) {                                                     \
-      FIREBASE_NAMESPACE::LogError(                                           \
+      FIREBASE_NAMESPACE::LogError(                                         \
           FIREBASE_ASSERT_MESSAGE_PREFIX FIREBASE_EXPAND_STRINGIFY(         \
               expression));                                                 \
-      FIREBASE_NAMESPACE::LogAssert(__VA_ARGS__);                             \
+      FIREBASE_NAMESPACE::LogAssert(__VA_ARGS__);                           \
     }                                                                       \
-  }
+  } while (false)
 
 // Assert condition is true otherwise display the specified expression,
 // message and abort. Compiled out of release builds.

database/src/desktop/persistence/prune_forest.cc

@@ -79,7 +79,7 @@ const PruneForestRef PruneForestRef::GetChild(const Path& path) const {
 void PruneForestRef::Prune(const Path& path) {
   FIREBASE_DEV_ASSERT_MESSAGE(
       prune_forest_->RootMostValueMatching(path, KeepPredicate) == nullptr,
-      "Can't prune path that was kept previously!")
+      "Can't prune path that was kept previously!");
   if (prune_forest_->RootMostValueMatching(path, PrunePredicate) != nullptr) {
     // This path will already be pruned
   } else {