Revert "fix: add in test for the DLL"

This reverts commit ea27540.

Author: AustinBenoit

analytics/integration_test/CMakeLists.txt

@@ -83,7 +83,6 @@ set(FIREBASE_INTEGRATION_TEST_SRCS
 
 # The include directory for the testapp.
 include_directories(src)
-include_directories(${FIREBASE_CPP_SDK_DIR})
 
 # Firebase C++ SDK requires C++14.
 set (CMAKE_CXX_STANDARD 14)

analytics/integration_test/src/integration_test.cc

@@ -354,12 +354,4 @@ TEST_F(FirebaseAnalyticsTest, TestSetConsent) {
   did_test_setconsent_ = true;
 }
 
-TEST_F(FirebaseAnalyticsTest, TestIsAnalyticsDllLoaded) {
-#if defined(_WIN32)
-  EXPECT_TRUE(firebase::analytics::internal::IsAnalyticsDllLoaded());
-#else
-  GTEST_SKIP();
-#endif  // defined(_WIN32)
-}
-
 }  // namespace firebase_testapp_automated

analytics/src/analytics_android.cc

@@ -22,7 +22,6 @@
 #include <vector>
 
 #include "analytics/src/analytics_common.h"
-#include "analytics/src/analytics_internal.h"
 #include "analytics/src/include/firebase/analytics.h"
 #include "app/src/assert.h"
 #include "app/src/include/firebase/app.h"
@@ -166,8 +165,6 @@ namespace internal {
 // Determine whether the analytics module is initialized.
 bool IsInitialized() { return g_app != nullptr; }
 
-bool IsAnalyticsDllLoaded() { return false; }
-
 }  // namespace internal
 
 // Clean up the API.

analytics/src/analytics_internal.h

@@ -23,7 +23,6 @@
 #include "analytics/src/include/firebase/analytics.h"
 
 #include "analytics/src/analytics_common.h"
-#include "analytics/src/analytics_internal.h"
 #include "app/src/assert.h"
 #include "app/src/include/firebase/internal/mutex.h"
 #include "app/src/include/firebase/version.h"
@@ -134,8 +133,6 @@ void Initialize(const ::firebase::App& app) {
 // Determine whether the analytics module is initialized.
 bool IsInitialized() { return g_initialized; }
 
-bool IsAnalyticsDllLoaded() { return false; }
-
 }  // namespace internal
 
 // Terminate the API.

analytics/src/analytics_ios.mm

@@ -627,7 +627,7 @@ def _build_apple(
       "--XCodeCPP.frameworks", ",".join(framework_paths)
   ]
   # Internal integration tests require the SDK root as an include path.
-  if repo_dir:
+  if repo_dir and api_config.internal_testapp_path:
     xcode_patcher_args.extend(("--XCodeCPP.include", repo_dir))
   if os.path.isfile(entitlements_path):  # Not all testapps require entitlements
     logging.info("Entitlements file detected.")