Changed Variants arguemnts to const Variant& in DatabaseReferenceInternal

functions.

PiperOrigin-RevId: 249672366

Author: amablue

database/src/ios/database_reference_ios.h

@@ -17,6 +17,7 @@
 
 #include <map>
 #include <string>
+
 #include "app/src/include/firebase/future.h"
 #include "app/src/include/firebase/internal/common.h"
 #include "app/src/include/firebase/variant.h"
@@ -110,26 +111,27 @@ class DatabaseReferenceInternal : public QueryInternal {
 
   // Sets the priority of this field, which controls its sort
   // order relative to its siblings.
-  Future<void> SetPriority(Variant priority);
+  Future<void> SetPriority(const Variant& priority);
 
   // Gets the result of the most recent call to SetPriority().
   Future<void> SetPriorityLastResult();
 
   // Sets the data at this location to the given value.
-  Future<void> SetValue(Variant value);
+  Future<void> SetValue(const Variant& value);
 
   // Gets the result of the most recent call to SetValue().
   Future<void> SetValueLastResult();
 
   // Sets both the data and priority of this location. See SetValue() and
   // SetPriority() for context on the parameters.
-  Future<void> SetValueAndPriority(Variant value, Variant priority);
+  Future<void> SetValueAndPriority(const Variant& value,
+                                   const Variant& priority);
 
   // Get the result of the most recent call to SetValueAndPriority().
   Future<void> SetValueAndPriorityLastResult();
 
   // Updates the specified child keys to the given values.
-  Future<void> UpdateChildren(Variant values);
+  Future<void> UpdateChildren(const Variant& values);
 
   // Gets the result of the most recent call to either version of
   // UpdateChildren().

database/src/ios/database_reference_ios.mm

@@ -185,7 +185,7 @@ MutableData mutable_data(new MutableDataInternal(
       ref_future()->LastResult(kDatabaseReferenceFnRunTransaction));
 }
 
-Future<void> DatabaseReferenceInternal::SetPriority(Variant priority) {
+Future<void> DatabaseReferenceInternal::SetPriority(const Variant& priority) {
   SafeFutureHandle<void> handle = ref_future()->SafeAlloc<void>(kDatabaseReferenceFnSetPriority);
   if (SetValueAndPriorityLastResult().status() == kFutureStatusPending) {
     ref_future()->Complete(
@@ -204,7 +204,7 @@ MutableData mutable_data(new MutableDataInternal(
       static_cast<const Future<void>&>(ref_future()->LastResult(kDatabaseReferenceFnSetPriority));
 }
 
-Future<void> DatabaseReferenceInternal::SetValue(Variant value) {
+Future<void> DatabaseReferenceInternal::SetValue(const Variant& value) {
   SafeFutureHandle<void> handle = ref_future()->SafeAlloc<void>(kDatabaseReferenceFnSetValue);
   if (SetValueAndPriorityLastResult().status() == kFutureStatusPending) {
     ref_future()->Complete(handle, kErrorConflictingOperationInProgress, kErrorMsgConflictSetValue);
@@ -219,8 +219,8 @@ MutableData mutable_data(new MutableDataInternal(
   return static_cast<const Future<void>&>(ref_future()->LastResult(kDatabaseReferenceFnSetValue));
 }
 
-Future<void> DatabaseReferenceInternal::SetValueAndPriority(Variant value,
-                                                            Variant priority) {
+Future<void> DatabaseReferenceInternal::SetValueAndPriority(const Variant& value,
+                                                            const Variant& priority) {
   SafeFutureHandle<void> handle =
       ref_future()->SafeAlloc<void>(kDatabaseReferenceFnSetValueAndPriority);
   if (SetValueLastResult().status() == kFutureStatusPending) {
@@ -243,7 +243,7 @@ MutableData mutable_data(new MutableDataInternal(
       ref_future()->LastResult(kDatabaseReferenceFnSetValueAndPriority));
 }
 
-Future<void> DatabaseReferenceInternal::UpdateChildren(Variant values) {
+Future<void> DatabaseReferenceInternal::UpdateChildren(const Variant& values) {
   SafeFutureHandle<void> handle = ref_future()->SafeAlloc<void>(kDatabaseReferenceFnUpdateChildren);
   id values_id = VariantToId(values);
   if (!values.is_map()) {