From abb9f753d6d25480221816a11273e61724746a85 Mon Sep 17 00:00:00 2001 From: Tadej Date: Wed, 5 Nov 2025 10:08:44 +0100 Subject: [PATCH 1/5] fix(storage-resize-images): add missing recordStartEvent call --- storage-resize-images/CHANGELOG.md | 4 ++++ storage-resize-images/extension.yaml | 2 +- storage-resize-images/functions/src/index.ts | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/storage-resize-images/CHANGELOG.md b/storage-resize-images/CHANGELOG.md index 0e7d219ff..994795894 100644 --- a/storage-resize-images/CHANGELOG.md +++ b/storage-resize-images/CHANGELOG.md @@ -1,3 +1,7 @@ +## Version 0.3.1 + +fix - add missing recordStartEvent call (#2546) + ## Version 0.3.0 fix! - remove backfill, due to architectural flaws. diff --git a/storage-resize-images/extension.yaml b/storage-resize-images/extension.yaml index 69d3fec20..12e2f5a49 100644 --- a/storage-resize-images/extension.yaml +++ b/storage-resize-images/extension.yaml @@ -13,7 +13,7 @@ # limitations under the License. name: storage-resize-images -version: 0.3.0 +version: 0.3.1 specVersion: v1beta displayName: Resize Images diff --git a/storage-resize-images/functions/src/index.ts b/storage-resize-images/functions/src/index.ts index 5cb7034f5..1b100d668 100644 --- a/storage-resize-images/functions/src/index.ts +++ b/storage-resize-images/functions/src/index.ts @@ -149,6 +149,7 @@ const generateResizedImageHandler = async ( export const generateResizedImage = functions.storage .object() .onFinalize(async (object, context) => { + await events.recordStartEvent(object); await generateResizedImageHandler(object); await events.recordCompletionEvent({ context }); }); From c3b050d2e38cf761ff71974fb685832fb81f46b0 Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Mon, 1 Dec 2025 14:48:36 +0300 Subject: [PATCH 2/5] feat(storage-resize-images): add onStorageResize event --- storage-resize-images/extension.yaml | 6 ++++++ storage-resize-images/functions/src/events.ts | 16 ++++++++++++++++ storage-resize-images/functions/src/index.ts | 5 +++++ 3 files changed, 27 insertions(+) diff --git a/storage-resize-images/extension.yaml b/storage-resize-images/extension.yaml index 12e2f5a49..8c65ccffd 100644 --- a/storage-resize-images/extension.yaml +++ b/storage-resize-images/extension.yaml @@ -426,6 +426,12 @@ events: description: Occurs when the function is settled. Provides no customized data other than the context. + + - type: firebase.extensions.storage-resize-images.v1.onStorageResize + description: + Occurs when an image resize operation completes successfully. This event + is only triggered when shouldResize returns true and the resize operation + succeeds. The event will contain details about the resized images. # Lifecycle events disabled - backfill feature commented out # lifecycleEvents: # onInstall: diff --git a/storage-resize-images/functions/src/events.ts b/storage-resize-images/functions/src/events.ts index f3168b4dc..67263910c 100644 --- a/storage-resize-images/functions/src/events.ts +++ b/storage-resize-images/functions/src/events.ts @@ -60,3 +60,19 @@ export const recordCompletionEvent = async (data: string | object) => { data, }); }; + +export const recordStorageResizeEvent = async ({ + subject, + data, +}: { + subject: string; + data: string | object; +}) => { + if (!eventChannel) return; + + return eventChannel.publish({ + type: getEventType("onStorageResize"), + subject, + data, + }); +}; diff --git a/storage-resize-images/functions/src/index.ts b/storage-resize-images/functions/src/index.ts index 1b100d668..d92cb70b4 100644 --- a/storage-resize-images/functions/src/index.ts +++ b/storage-resize-images/functions/src/index.ts @@ -59,6 +59,11 @@ const generateResizedImageHandler = async ( return; } + await events.recordStorageResizeEvent({ + subject: object.name, + data: { input: object }, + }); + const bucket = admin.storage().bucket(object.bucket); const filePath = object.name; // File path in the bucket. const parsedPath = path.parse(filePath); From 87c4a17344227338fe0f78f4e1c3142ac460ee91 Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Mon, 1 Dec 2025 14:51:14 +0300 Subject: [PATCH 3/5] docs(storage-resize-images): update changelog --- storage-resize-images/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/storage-resize-images/CHANGELOG.md b/storage-resize-images/CHANGELOG.md index 994795894..e2e4371e0 100644 --- a/storage-resize-images/CHANGELOG.md +++ b/storage-resize-images/CHANGELOG.md @@ -1,6 +1,7 @@ ## Version 0.3.1 fix - add missing recordStartEvent call (#2546) +feat - add new onStorageResize event ## Version 0.3.0 From aa58fa598e52ec54b58446d4cc3d512283525e6b Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Mon, 1 Dec 2025 19:08:06 +0300 Subject: [PATCH 4/5] chore(storage-resize-images): add onStartResize --- storage-resize-images/CHANGELOG.md | 2 +- storage-resize-images/extension.yaml | 4 ++-- storage-resize-images/functions/src/events.ts | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/storage-resize-images/CHANGELOG.md b/storage-resize-images/CHANGELOG.md index e2e4371e0..f12933d6b 100644 --- a/storage-resize-images/CHANGELOG.md +++ b/storage-resize-images/CHANGELOG.md @@ -1,7 +1,7 @@ ## Version 0.3.1 fix - add missing recordStartEvent call (#2546) -feat - add new onStorageResize event +feat - add new onStartResize event ## Version 0.3.0 diff --git a/storage-resize-images/extension.yaml b/storage-resize-images/extension.yaml index 8c65ccffd..ea4fb4212 100644 --- a/storage-resize-images/extension.yaml +++ b/storage-resize-images/extension.yaml @@ -427,11 +427,11 @@ events: Occurs when the function is settled. Provides no customized data other than the context. - - type: firebase.extensions.storage-resize-images.v1.onStorageResize + - type: firebase.extensions.storage-resize-images.v1.onStartResize description: Occurs when an image resize operation completes successfully. This event is only triggered when shouldResize returns true and the resize operation - succeeds. The event will contain details about the resized images. + succeeds. # Lifecycle events disabled - backfill feature commented out # lifecycleEvents: # onInstall: diff --git a/storage-resize-images/functions/src/events.ts b/storage-resize-images/functions/src/events.ts index 67263910c..6b548d766 100644 --- a/storage-resize-images/functions/src/events.ts +++ b/storage-resize-images/functions/src/events.ts @@ -61,7 +61,7 @@ export const recordCompletionEvent = async (data: string | object) => { }); }; -export const recordStorageResizeEvent = async ({ +export const recordStartResizeEvent = async ({ subject, data, }: { @@ -71,7 +71,7 @@ export const recordStorageResizeEvent = async ({ if (!eventChannel) return; return eventChannel.publish({ - type: getEventType("onStorageResize"), + type: getEventType("onStartResize"), subject, data, }); From 861cf064166f6dddc1ec61f0c394931c31d365ae Mon Sep 17 00:00:00 2001 From: HassanBahati Date: Mon, 1 Dec 2025 19:13:22 +0300 Subject: [PATCH 5/5] chore(storage-resize-images): add onStartResize event --- storage-resize-images/functions/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage-resize-images/functions/src/index.ts b/storage-resize-images/functions/src/index.ts index d92cb70b4..6a4a380cb 100644 --- a/storage-resize-images/functions/src/index.ts +++ b/storage-resize-images/functions/src/index.ts @@ -59,7 +59,7 @@ const generateResizedImageHandler = async ( return; } - await events.recordStorageResizeEvent({ + await events.recordStartResizeEvent({ subject: object.name, data: { input: object }, });