feat: Auto-generate meta descriptions for operators and countries #471
Conversation
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
therobrob
left a comment
therobrob
left a comment
There was a problem hiding this comment.
Good idea to auto-generate the meta-description 👍🏼 nevertheless there is the option to overwrite it. I’ve made some comments, maybe you could check them before merging 😊
| operator: "{{ .File.ContentBaseName }}" | ||
| params: | ||
| # Der Name wird in den Meta-Beschreibungen verwendet. | ||
| name: |
There was a problem hiding this comment.
„name“ seems quite general, we use this term only for meta-description I think? Could we use a more specific term like nickname or meta-description-name?
| - "bulgaria" | ||
| operator: "bdz" | ||
| params: | ||
| name: Balgarski Darschawni Schelesnizi (BDŽ) |
There was a problem hiding this comment.
Why do we sometimes use the abbreviation and sometimes the full length name? There are different namings for now.. for example:
- Balgarski Darschawni Schelesnizi (BDŽ)
- DSB
- Trenitalia (FS)
- National Rail
There was a problem hiding this comment.
Honestly not sure, I just took the current meta-descriptions for the beginning. If there is no reason to customize it, we can also just use the page title and get rid of the overwrite logic.
Resolves #470