Certificate authentication issue

[vaibhav-db]

Authentication issue

Even after creating ClientCertificateCredential bean, still it try to create the MicrosoftAppCredentials and it except app password.

Expected Result:

Caused by: java.io.IOException: java.lang.IllegalArgumentException: clientSecret is null or empty
at com.microsoft.bot.connector.authentication.AppCredentialsInterceptor.intercept(AppCredentialsInterceptor.java:44) ~[bot-connector-4.14.3.jar:4.14.3]
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109) ~[okhttp-4.12.0.jar:na]
at com.microsoft.bot.restclient.interceptors.BaseUrlHandler.intercept(BaseUrlHandler.java:40) ~[bot-connector-4.14.3.jar:4.14.3]
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109) ~[okhttp-4.12.0.jar:na]
at com.microsoft.bot.restclient.interceptors.RequestIdHeaderInterceptor.intercept(RequestIdHeaderInterceptor.java:26) ~[bot-connector-4.14.3.jar:4.14.3]
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109) ~[okhttp-4.12.0.jar:na]
at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201) ~[okhttp-4.12.0.jar:na]
at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:517) ~[okhttp-4.12.0.jar:na]
... 3 common frames omitted
Caused by: java.lang.IllegalArgumentException: clientSecret is null or empty
at com.microsoft.aad.msal4j.ClientSecret.(ClientSecret.java:16) ~[msal4j-1.21.0.jar:1.21.0]
at com.microsoft.aad.msal4j.ClientCredentialFactory.createFromSecret(ClientCredentialFactory.java:33) ~[msal4j-1.21.0.jar:1.21.0]
at com.microsoft.bot.connector.authentication.CredentialsAuthenticator.(CredentialsAuthenticator.java:34) ~[bot-connector-4.14.3.jar:4.14.3]
at com.microsoft.bot.connector.authentication.MicrosoftAppCredentials.buildAuthenticator(MicrosoftAppCredentials.java:107) ~[bot-connector-4.14.3.jar:4.14.3]
at com.microsoft.bot.connector.authentication.AppCredentials.getAuthenticator(AppCredentials.java:173) ~[bot-connector-4.14.3.jar:4.14.3]
at com.microsoft.bot.connector.authentication.AppCredentials.getToken(AppCredentials.java:146) ~[bot-connector-4.14.3.jar:4.14.3]
at com.microsoft.bot.connector.authentication.AppCredentialsInterceptor.intercept(AppCredentialsInterceptor.java:42) ~[bot-connector-4.14.3.jar:4.14.3]
... 10 common frames omitted

[vaibhav-db]

@robmoffat

[robmoffat]

what went wrong here? Did you not get to test this first?

[vaibhav-db]

Issue is on com.microsoft.bot.builder.BotFrameworkAdapter

/**
* Creates an AppCredentials object for the specified appId and scope.
*
* @param appId The appId.
* @param scope The scope.
* @return An AppCredentials object.
*/
protected CompletableFuture buildAppCredentials(String appId, String scope) {
return credentialProvider.getAppPassword(appId).thenApply(appPassword -> {
AppCredentials credentials = channelProvider != null && channelProvider.isGovernment()
? new MicrosoftGovernmentAppCredentials(appId, appPassword, null, scope)
: new MicrosoftAppCredentials(appId, appPassword, null, scope);
return credentials;
});
}

[vaibhav-db]

I had tested on sample connectivity. It was working fine. when I had deployed with MS Teams app, SDK framework throw the exception.

[robmoffat]

ok. how can I help? You want a call? finos.org/bookrob

[vaibhav-db]

I found the solution.. I will discuss with you.. Doing testing around that..

[robmoffat]

nice. Can you write a unit test? So we don't merge broken code in the future...