Code Quality: Use concrete types when possible for improved performance (#15093)

Author: gumbarros

src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs

@@ -66,7 +66,7 @@ bool filterMenuItemsImpl(string menuItem) => !string.IsNullOrEmpty(menuItem)
 		}
 
 		private static void LoadMenuFlyoutItem(
-			IList<ContextMenuFlyoutItemViewModel> menuItemsListLocal,
+			List<ContextMenuFlyoutItemViewModel> menuItemsListLocal,
 			ContextMenu contextMenu,
 			IEnumerable<Win32ContextMenuItem> menuFlyoutItems,
 			CancellationToken cancellationToken,

src/Files.App/Data/Models/ItemViewModel.cs

@@ -39,7 +39,7 @@ public sealed class ItemViewModel : ObservableObject, IDisposable
 		private readonly AsyncManualResetEvent gitChangedEvent;
 		private readonly DispatcherQueue dispatcherQueue;
 		private readonly JsonElement defaultJson = JsonSerializer.SerializeToElement("{}");
-		private readonly IStorageCacheController fileListCache = StorageCacheController.GetInstance();
+		private readonly StorageCacheController fileListCache = StorageCacheController.GetInstance();
 		private readonly string folderTypeTextLocalized = "Folder".GetLocalizedResource();
 
 		private Task? aProcessQueueAction;

src/Files.App/Services/UpdateService.cs

@@ -16,7 +16,7 @@ namespace Files.App.Services
 	internal sealed class UpdateService : ObservableObject, IUpdateService
 	{
 		private StoreContext? _storeContext;
-		private IList<StorePackageUpdate>? _updatePackages;
+		private List<StorePackageUpdate>? _updatePackages;
 
 		private bool IsMandatory => _updatePackages?.Where(e => e.Mandatory).ToList().Count >= 1;
 

src/Files.App/Utils/RecycleBin/RecycleBinManager.cs

@@ -12,7 +12,7 @@ public sealed class RecycleBinManager
 	{
 		private static readonly Lazy<RecycleBinManager> lazy = new(() => new RecycleBinManager());
 
-		private IList<SystemIO.FileSystemWatcher>? binWatchers;
+		private List<SystemIO.FileSystemWatcher>? binWatchers;
 
 		public event SystemIO.FileSystemEventHandler? RecycleBinItemCreated;
 

src/Files.App/Utils/Storage/Collection/BulkConcurrentObservableCollection.cs

@@ -487,7 +487,7 @@ public void Order(Func<List<T>, IEnumerable<T>> func)
 
 		public void OrderOne(Func<List<T>, IEnumerable<T>> func, T item)
 		{
-			IList<T> result;
+			List<T> result;
 			lock (syncRoot)
 			{
 				result = func.Invoke(collection).ToList();

src/Files.App/Utils/Storage/Collection/ConcurrentCollection.cs

@@ -243,7 +243,7 @@ public void Order(Func<List<T>, IEnumerable<T>> func)
 
 		public void OrderOne(Func<List<T>, IEnumerable<T>> func, T item)
 		{
-			IList<T> result;
+			List<T> result;
 
 			lock (syncRoot)
 			{

src/Files.App/Utils/Storage/Enumerators/Win32StorageEnumerator.cs

@@ -17,7 +17,7 @@ public static class Win32StorageEnumerator
 
 		private static readonly string folderTypeTextLocalized = "Folder".GetLocalizedResource();
 
-		private static readonly IStorageCacheController fileListCache = StorageCacheController.GetInstance();
+		private static readonly StorageCacheController fileListCache = StorageCacheController.GetInstance();
 
 		public static async Task<List<ListedItem>> ListEntries(
 			string path,

src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs

@@ -24,7 +24,7 @@ public sealed class FilesystemHelpers : IFilesystemHelpers
 
 		private IShellPage associatedInstance;
 		private readonly IJumpListService jumpListService;
-		private IFilesystemOperations filesystemOperations;
+		private ShellFilesystemOperations filesystemOperations;
 
 		private ItemManipulationModel? itemManipulationModel => associatedInstance.SlimContentPage?.ItemManipulationModel;
 

src/Files.App/Utils/Storage/StorageItems/ZipStorageFolder.cs

@@ -517,7 +517,7 @@ private static bool CheckAccess(Stream stream)
 				return false;
 			}
 		}
-		private static async Task<bool> CheckAccess(IStorageFile file)
+		private static async Task<bool> CheckAccess(BaseStorageFile file)
 		{
 			return await SafetyExtensions.IgnoreExceptions(async () =>
 			{

src/Files.App/ViewModels/Properties/CompatibilityViewModel.cs

@@ -116,7 +116,7 @@ public bool SetCompatibilityOptions()
 			return WindowsCompatibilityService.SetCompatibilityOptionsForPath(ItemPath, CompatibilityOptions);
 		}
 
-		private Task ExecuteRunTroubleshooterCommand()
+		private Task<bool> ExecuteRunTroubleshooterCommand()
 		{
 			return LaunchHelper.RunCompatibilityTroubleshooterAsync(ItemPath);
 		}