Code Quality: Fixed caused by useless predicate (#15126)

Author: gumbarros

src/Files.App (Package)/Package.appxmanifest

@@ -168,7 +168,6 @@
                 <ActivatableClass ActivatableClassId="Files.App.Server.AppInstanceMonitor" />
                 <ActivatableClass ActivatableClassId="Files.App.Server.Database.FileTagsDatabase" />
                 <ActivatableClass ActivatableClassId="Files.App.Server.Database.LayoutPreferencesDatabase" />
-                <ActivatableClass ActivatableClassId="Files.App.Server.Database.LayoutPreferencesFilterPredicate" />
                 <ActivatableClass ActivatableClassId="Files.App.Server.Database.LayoutPreferencesUpdateAction" />
                 <ActivatableClass ActivatableClassId="Files.App.Server.Data.ColumnPreferences" />
                 <ActivatableClass ActivatableClassId="Files.App.Server.Data.ColumnPreferencesItem" />

src/Files.App.Server/Database/LayoutPreferencesDatabase.cs

@@ -75,25 +75,18 @@ public void SetPreferences(string filePath, ulong? frn, LayoutPreferencesItem? p
 			}
 		}
 
-		public void ResetAll(LayoutPreferencesFilterPredicate? predicate)
+		public void ResetAll()
 		{
 			var col = _database.GetCollection<LayoutPreferences>(LayoutPreferences);
 
-			if (predicate is null)
-			{
-				col.DeleteAll();
-			}
-			else
-			{
-				col.DeleteMany(x => predicate(x));
-			}
+			col.DeleteAll();
 		}
 
-		public void ApplyToAll(LayoutPreferencesUpdateAction updateAction, LayoutPreferencesFilterPredicate? predicate)
+		public void ApplyToAll(LayoutPreferencesUpdateAction updateAction)
 		{
 			var col = _database.GetCollection<LayoutPreferences>(LayoutPreferences);
 
-			var allDocs = predicate is null ? col.FindAll() : col.Find(x => predicate(x));
+			var allDocs = col.FindAll();
 
 			foreach (var doc in allDocs)
 			{
@@ -159,6 +152,5 @@ public string Export()
 		}
 	}
 
-	public delegate bool LayoutPreferencesFilterPredicate(LayoutPreferences preference);
 	public delegate void LayoutPreferencesUpdateAction(LayoutPreferences preference);
 }

src/Files.App/Helpers/Layout/LayoutPreferencesDatabaseManager.cs

@@ -135,15 +135,14 @@ public void SetPreferences(string filePath, ulong? frn, LayoutPreferencesItem? p
 			_database.SetPreferences(filePath, frn, ToDatabaseEntity(preferencesItem));
 		}
 
-		public void ResetAll(Func<LayoutPreferencesDatabaseItem, bool>? predicate = null)
+		public void ResetAll()
 		{
-			_database.ResetAll(item => predicate?.Invoke(FromDatabaseEntity(item)) ?? true);
+			_database.ResetAll();
 		}
 
-		public void ApplyToAll(Action<LayoutPreferencesDatabaseItem> updateAction, Func<LayoutPreferencesDatabaseItem, bool>? predicate = null)
+		public void ApplyToAll(Action<LayoutPreferencesDatabaseItem> updateAction)
 		{
-			_database.ApplyToAll(item => updateAction.Invoke(FromDatabaseEntity(item)),
-				item => predicate?.Invoke(FromDatabaseEntity(item)) ?? true);
+			_database.ApplyToAll(item => updateAction.Invoke(FromDatabaseEntity(item)));
 		}
 
 		public void Import(string json)